Scc 5050 make async #600
Scc 5050 make async #600
Conversation
lib/utils/resource-helpers.js
Outdated
| // Create promise to resolve deliveryLocationTypes by patron type: | ||
| const lookupPatronType = async function (params) { | ||
| try { | ||
| await AvailableDeliveryLocationTypes.getScholarRoomByPatronId(params.patronId) |
There was a problem hiding this comment.
Doesn't seem like this returns anything?
There was a problem hiding this comment.
Yeah, the only purpose of this function is to throw an error if something goes wrong. Maybe a more descriptive comment would clear that up?
There was a problem hiding this comment.
Looks like getScholarRoomByPatronId returns a location code, which you use to determine delivery locations
There was a problem hiding this comment.
good catch, added a return
| } | ||
| } | ||
|
|
||
| const makeRelevanceReport = (params) => (r, ind) => { |
There was a problem hiding this comment.
I appreciate that this came from even more confusing code, but let's make it clearer what's happening here through documentation and better var names?
lib/resources.js
Outdated
| itemUri: (uri) => { | ||
| return { term: { 'items.uri': uri } } | ||
| } | ||
| const [resp] = Promise.all([fetchItems, lookupPatronType]) |
There was a problem hiding this comment.
This doesn't seem right. I think you probably want to destructure as const [items, scholarRoomCode] = ...
lib/utils/resource-helpers.js
Outdated
|
|
||
| app.logger.debug('Resources#itemsByFilter', body) | ||
| return app.esClient.search(body) | ||
| .then((resp) => { |
There was a problem hiding this comment.
This is still using promise chaining. can you update to make async/await?
There was a problem hiding this comment.
Updated to use async and cleaned up
lib/resources.js
Outdated
| itemUri: (uri) => { | ||
| return { term: { 'items.uri': uri } } | ||
| } | ||
| const [resp] = Promise.all([fetchItems, lookupPatronType]) |
There was a problem hiding this comment.
I believe this Promise.all needs to be await-ed
Beginning of refactor of
discovery-api, focusing onlib/routesThe goal is to make the
lib/routesfile easier to read, with every method corresponding to a route, and each route-related function being relatively simple.Most of this PR is just moving code out of the
lib/routesfile to util files.In addition, the methods in
lib/routesare rewritten using async/await instead of promises.I'd like to rewrite the
elastic-body-buildermethods as well, but that is only started. In particular the body for finding by uri uses the newinnerHitsmethod instead ofaddInnerHits, but it isn't quite working for the search request, so that method still needsaddInnerHits. Reworking the body builder is still ongoing.