Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this pull request associated with an issue(s)?
No.
Description
After #232
MDBuffershould be a drop-in replacement forbuffer::Eigen. The goal of this PR is to move TensorWrapper closer to the spirit of the original design where the buffer objects are backend-agnostic. To this end, this PR will:buffer::Eigen(and the associated infrastructure)MDBuffertoContiguous(see TODOs for caveats)make_contiguous_buffer(names subject to change given above caveat).floating_point_dispatchis now the responsibility of WTF not TensorWrapper.TODOs
Contiguousis the right name. In particular, where does a non-contiguous buffer fit? What about a hierarchical buffer?