Skip to content

Add i4h workflows component#225

Draft
wyli wants to merge 1 commit into
NVIDIA:mainfrom
wyli:add-i4h-workflows-component
Draft

Add i4h workflows component#225
wyli wants to merge 1 commit into
NVIDIA:mainfrom
wyli:add-i4h-workflows-component

Conversation

@wyli
Copy link
Copy Markdown
Member

@wyli wyli commented Jun 2, 2026

Onboarding type

  • New product onboarding (new components.d/<slug>.yml file)
  • Other (catalog change, README fix, infrastructure, etc.)

For new product onboarding — author affirmations

By submitting this PR, I confirm on behalf of my team:

  • Skills cleared for open source release per NVIDIA's internal IP review process (six-question check, all answers affirmative)
  • License selected: Apache 2.0 / CC-BY 4.0 / Dual (Apache 2.0 + CC-BY 4.0). Specify: Apache 2.0
  • No new license or new third-party component introduced beyond what the source repo already carries
  • Source repo is public and under an NVIDIA-owned GitHub org
  • .agents/skills/ or skills/ path used for new entries (or existing path retained for legacy entries per components.d/<slug>.yml)

NVIDIA contributors: see the internal onboarding guide for the IP review process details and license selection.

Reviewer checklist (OSS Skills PIC)

  • Author confirmations above are checked
  • components.d/<slug>.yml entry valid (required fields, unique catalog_dir, path exists in source repo, filename slug matches name)
  • SKILL.md frontmatter spec-compliant (at least one sampled)
  • No new license or third-party dependency requiring OSRB filing

All PRs

  • All commits signed off with DCO (git commit -s).
    If you forgot, run git rebase --signoff origin/main && git push --force-with-lease to retroactively sign all commits in your branch.

Other context (for non-onboarding PRs)

@wyli wyli force-pushed the add-i4h-workflows-component branch from 6e91d13 to 0d9c1ba Compare June 2, 2026 07:32
Co-authored-by: Codex <noreply@openai.com>
Signed-off-by: Wenqi Li <wenqil@nvidia.com>
@wyli wyli force-pushed the add-i4h-workflows-component branch from 0d9c1ba to efb8059 Compare June 2, 2026 15:26
@mosheabr
Copy link
Copy Markdown
Collaborator

mosheabr commented Jun 2, 2026

Thanks Wenqi — format-wise this is in great shape (flat-layout, 14 enumerated i4h-workflow-* prefixed entries, source repo public + Apache-2.0). Holding the merge — two blockers on the source-repo side.

1. Skills are at the legacy .claude/skills/ path, not the canonical skills/ path

A repo-wide search on isaac-for-healthcare/i4h-workflows finds your 14 SKILL.md files, but they're at:

.claude/skills/i4h-workflow/SKILL.md
.claude/skills/i4h-workflow-setup/SKILL.md
.claude/skills/i4h-workflow-create/SKILL.md
...

The components.d entry in this PR declares path: skills/i4h-workflow/ etc. — that path returns 404 on main.

Two options to resolve:

  • (a) Move the skills from .claude/skills/ to skills/ on your source repo. This is the recommended path per Mohit Gupta's 2026-05-15 directive — canonical is now <repo>/skills/<skill-name>/SKILL.md. .claude/skills/ is deprecated for new entries.
  • (b) Change the components.d entry to path: .claude/skills/i4h-workflow/ etc. Less ideal (locks the catalog entry to the legacy path).

Recommend (a). Same convention Medical AI Skills follows (your prior onboarding).

2. Only SKILL.md files exist — missing signing artifacts

Repo-wide search finds 14 SKILL.md files but no skill.oms.sig, skill-card.md, evals/evals.json, or BENCHMARK.md on any branch.

The catalog enforcement gate requires the full 5-artifact set per skill. Without these, sync would drop all 14 i4h-workflow-* skills even with the path corrected.

→ Run the NVCARPS signing flow on the source repo (GitHub-first guide: Confluence 3483240468) for each of the 14 skills. That produces the sig, card, evals, and BENCHMARK. NVCARPS-EVAL Tier 3 generates the eval dataset.

Mohit Gupta and Sayali Kandarkar are great resources if you hit anything on the signing flow.

Once both blockers clear

Ping me here and I'll re-verify (source path check + model_signing verify + sample artifact review), then merge same day. No urgency — this is structural pre-staging which is exactly the right move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants