Add physical-ai-data-factory component config#198
Conversation
Signed-off-by: Adityan Jothi <ajothi@nvidia.com>
7e00bab to
264abf7
Compare
|
Thanks for the PR Aditya! Source content ( 1. DCO sign-off (CI is failing)The DCO check is currently failing because commit git commit --amend -s --no-edit
git push --force-with-leaseOr if there are multiple commits, 2. Group under the existing "Physical AI" productPer the product owner direction, all name: physical-ai-data-factoryto: name: Physical AIThis way the catalog shows one consolidated "Physical AI" row covering all 7 skills (5 currently manually-staged from the internal Skill Hub repo + your 2 newly-synced from 3. Add
|
Signed-off-by: Adityan Jothi <ajothi@nvidia.com>
|
Addressed the concerns, let me know if that looks @mosheabr . Thanks ! |
|
Thanks Aditya — all the feedback addressed cleanly. DCO + Verify Authors both green, naming aligned to One last sequencing note before we merge: this PR groups under #200 ( I'm holding the merge of this PR until #200 is in. Should be a same-day turnaround. Tagging @sayalinvidia for visibility. |
Today the script emits one README row per yml entry — one row from each components.d/<product>.yml plus one row from each entry in manual-components.yml. When two entries share the same display `name` (synced + manual under the same product), they render as two separate rows with the same product name. This blocks the upcoming Physical AI Data Factory onboarding (PR #198), which adds a components.d entry named "Physical AI" — same name as the existing manual entry that covers the 5 omniverse-* / physical-ai-* skills from the internal Skill Hub. Aggregation logic: - Both loops now emit structured TSV (one column per cell, plus an is_manual flag) rather than pre-formatted markdown rows. - An awk pass groups rows by lowercase name; for groups of 2+ entries: - catalog cells are concatenated with the existing " · " separator - skill counts are summed - synced row's metadata (description, source, version, link cells) wins over the manual row's em-dash defaults - Single-entry rows pass through unchanged, so existing products with no name collision render byte-identically to today. Verified locally: - Current main state (only Physical AI in manual): renders one row, identical output to pre-aggregation behavior. - Simulated PR #198 landing with `name: Physical AI` (5 manual + 2 synced): renders one consolidated row with 7 skills, synced source cell, real link cells from the synced repo (issues, discussions, contributing, security). Signed-off-by: Moshe Abramovitch <moshea@nvidia.com>
Onboarding type
components.d/<slug>.ymlfile)This PR onboards two new skills from NVIDIA/physical-ai-data-factory, grouped under the existing Physical AI product entry alongside the
omniverse-*/physical-ai-*skills:physical-ai-defect-image-generationphysical-ai-video-data-augmentationFor new product onboarding — author affirmations
By submitting this PR, I confirm on behalf of my team:
skills/path used for new entriesReviewer checklist (OSS Skills PIC)
components.d/<slug>.ymlentry valid (required fields, uniquecatalog_dir, path exists in source repo, filename slug matches name)SKILL.mdfrontmatter spec-compliant (at least one sampled)All PRs
git commit -s).