Remove orphan skills/Megatron-Bridge/ from legacy nested layout#153
Merged
Conversation
PR #151 migrated NeMo MBridge to flat layout: the new components.d/nemo-mbridge.yml registers 20 skills at flat top-level paths (skills/nemo-mbridge-*/) and the old components.d/megatron-bridge.yml sweep entry was deleted. The previous catalog content under skills/Megatron-Bridge/ (a single nested skill mbridge-recipe-recommender from the legacy layout) was left behind by the sync — anti-pattern #1: sync writes content for referenced paths but does not garbage-collect directories that are no longer referenced by any components.d entry. Removing it here completes the migration. Authoritative content for NeMo MBridge now lives at skills/nemo-mbridge-*/ once the next sync runs, with no duplicate or stale path. Signed-off-by: Moshe Abramovitch <moshea@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the orphan `skills/Megatron-Bridge/` directory left behind by the flat-layout migration in PR #151.
Context
PR #151 (Chen Cui) migrated NeMo MBridge to the flat layout. The new `components.d/nemo-mbridge.yml` registers 20 customer-facing skills at flat top-level paths (`skills/nemo-mbridge-*/`), and the old sweep-style `components.d/megatron-bridge.yml` was deleted in the same PR.
The catalog still contains `skills/Megatron-Bridge/mbridge-recipe-recommender/` — a single nested skill from the legacy layout. Sync workflow writes content for referenced paths but does not garbage-collect directories that are no longer referenced (anti-pattern #1 in the catalog-pr-reviewer skill).
After this merges
Authoritative content for NeMo MBridge lives at `skills/nemo-mbridge-*/` (populated by the next sync from the renamed source paths). The old nested `skills/Megatron-Bridge/` is fully removed.
Test plan
🤖 Generated with Claude Code