fix(nvidia-skills): correct include_skills paths after catalog flatten#152
Closed
bryan-anthropic wants to merge 1 commit into
Closed
fix(nvidia-skills): correct include_skills paths after catalog flatten#152bryan-anthropic wants to merge 1 commit into
bryan-anthropic wants to merge 1 commit into
Conversation
plugins.d/nvidia-skills.yml curated two cuOpt skills via
skills/cuopt/<skill>/, but the catalog no longer nests cuOpt skills
under a cuopt/ directory — they now live directly at skills/<skill>/.
Because the paths no longer resolve, expand_skill_paths() in
build-plugins.py soft-skips both entries (by design, to avoid blocking
the daily sync on curation drift), so the build regenerates
plugins/nvidia-skills/ with an empty skills/ tree and the plugin ships
with no skills.
Update the two include_skills paths to the current catalog layout and
regenerate the bundle with:
.github/scripts/build-plugins.py --only nvidia-skills
This restores cuopt-routing-api-python and cuopt-user-rules under
plugins/nvidia-skills/skills/. `claude plugin validate` passes on the
rebuilt bundle.
Signed-off-by: Bryan Thompson <bthompson@anthropic.com>
Collaborator
|
Thanks for catching this Bryan — really appreciate the quick fix on the include_skills paths after the catalog flatten. Closing as superseded. The plugin curation has been updated internally since ( Thanks again for flagging — and for keeping an eye on the build output. Ping me anytime you spot drift like this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
nvidia-skillsplugin currently builds with an emptyskills/tree, so it installs without any skills.plugins.d/nvidia-skills.ymlcurates two cuOpt skills viaskills/cuopt/<skill>/, but the catalog was flattened — those skills now live directly atskills/cuopt-routing-api-python/andskills/cuopt-user-rules/(nocuopt/parent directory). Since the configured paths no longer resolve,expand_skill_paths()inbuild-plugins.pysoft-skips both entries (by design, so curation drift doesn't block the daily sync), and the build regeneratesplugins/nvidia-skills/with an emptyskills/tree.This is the
plugins.d/companion to #122 ("components.d/cuopt: flat layout migration + remove orphanskills/cuopt/"). That PR migrated the cuOpt catalog to the flat layout and removedskills/cuopt/; this PR updates the one remaining reference to the old path — thenvidia-skillsplugin curation.Fix
Point the two
include_skillsentries at the current catalog layout and regenerate the bundle:This is the only source change; the
plugins/nvidia-skills/skills/tree in this PR is the regenerated build output.Verification
.github/scripts/build-plugins.py --only nvidia-skills --check→✓ no driftclaude plugin validate plugins/nvidia-skills→✔ Validation passedcuopt-routing-api-python,cuopt-user-rules) withSKILL.md, references, evals, andskill.oms.sigsignatures intact.