Remove orphan skills/deepstream/ from pre-flat-layout era#116
Merged
Conversation
PR #109 flattened components.d/deepstream.yml to put DeepStream skills at top-level: skills/deepstream-dev/ and skills/deepstream-import-vision-model/. The next sync (PR #110) correctly mirrored content into those flat locations. However, the previous nested skills/deepstream/ directory (with the same two skills under a 'deepstream' parent dir) was left behind by the sync — anti-pattern #1 in the catalog-pr-reviewer skill: the sync workflow doesn't auto-clean directories that are no longer referenced by any components.d/<slug>.yml entry. Removing it here to eliminate the duplicate and complete the flat-layout cutover. Authoritative content now lives at: - skills/deepstream-dev/ - skills/deepstream-import-vision-model/ Signed-off-by: Moshe Abramovitch <moshea@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the orphan `skills/deepstream/` directory left behind by the flat-layout cutover.
Why
PR #109 restructured `components.d/deepstream.yml` to flat layout. The subsequent sync (PR #110) correctly mirrored both DeepStream skills into their new flat-layout homes at `skills/deepstream-dev/` and `skills/deepstream-import-vision-model/`. But the previous nested `skills/deepstream/` directory (with the same two skill names under a `deepstream` parent dir) was left behind — the sync workflow only writes the directories its `components.d` entries reference; it doesn't garbage-collect old directories. This matches anti-pattern #1 in the catalog-pr-reviewer skill.
Result
The DeepStream skills now exist in exactly one canonical location each:
53 files / -20,242 lines removed (the duplicate copies under `skills/deepstream//`).
Test plan
🤖 Generated with Claude Code