Enhanced support for memory-tracking raft resources#3004
Merged
Conversation
achirkin
added
improvement
achirkin
changed the title
bdice
approved these changes
Apr 24, 2026
Comment on lines
+75
to
+79
| // NVCC injects __host__ __device__ on std::shared_ptr special members, | ||
| // which makes the *implicit* or *defaulted* special members __host__ | ||
| // __device__ too. That conflicts with Upstream types whose special | ||
| // members are __host__ only (e.g. rmm::device_async_resource_ref). | ||
| // User-defined bodies (not = default) force plain __host__ execution space. |
Contributor
There was a problem hiding this comment.
Good find. Are there changes you would suggest for RMM or CCCL?
Contributor
Author
There was a problem hiding this comment.
Thanks! I think, CCCL/rrm are fine, because the cuda::mr::shared_resource defines the copy/move constructors explicitly.
cjnolet
reviewed
May 6, 2026
tfeher
reviewed
May 13, 2026
tfeher
left a comment
tfeher
left a comment
Contributor
There was a problem hiding this comment.
Thanks Artem for the PR! Overall looks good, I have only one question regarding Thrust policy handling.
achirkin
force-pushed
the
enh-memory-resources
branch
from
aa09273 to
053b0c5
Compare
cjnolet
previously requested changes
May 18, 2026
achirkin
added
breaking
Contributor
Author
|
Moving this to 26.08 as 26.06 deadline is missed |
achirkin
dismissed
cjnolet’s stale review
The request was addresses (moved the headers to the core folder).
tfeher
approved these changes
Jun 15, 2026
tfeher
left a comment
tfeher
left a comment
Contributor
There was a problem hiding this comment.
Thanks Artem for the update, LGTM.
Contributor
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
statistics_adaptor.hppto compile via nvcc (see code comment)memory_stats_resources. In constrast tomemory_tracking_resourcesthis doesn't stream the memory usage online, but only reports the overall usage metrics.breaking change: moved raft/util/memory_tracking_resources.hpp -> raft/core/memory_tracking_resources.hpp