Update shard tensor ring attention example#1665
Merged
Merged
Conversation
…ttention results directory
Contributor
Greptile SummaryThis PR updates the ring-attention benchmark script to write JSON results by default (opt-out via
Important Files Changed
Reviews (1): Last reviewed commit: "Update shard tensor ring attention to us..." | Re-trigger Greptile |
negin513
reviewed
May 21, 2026
| ), | ||
| ) | ||
| parser.add_argument( | ||
| "--print-only", |
Member
There was a problem hiding this comment.
Tiny consistency nitpick: every other flag in this file is underscore-cased (--results_dir, ...) and --print-only is the only one that is - based. Would it make sense to use --print_only instead?
negin513
approved these changes
May 21, 2026
Member
negin513
left a comment
There was a problem hiding this comment.
LGTM! Just a few very minor comments inline.
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…k_sharded_attention.py Co-authored-by: Negin Sobhani <negin513@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now, the generation script will use the expected default results directory.
PhysicsNeMo Pull Request
Description
Checklist
Dependencies
Review Process
All PRs are reviewed by the PhysicsNeMo team before merging.
Depending on which files are changed, GitHub may automatically assign a maintainer for review.
We are also testing AI-based code review tools (e.g., Greptile), which may add automated comments with a confidence score.
This score reflects the AI’s assessment of merge readiness and is not a qualitative judgment of your work, nor is
it an indication that the PR will be accepted / rejected.
AI-generated feedback should be reviewed critically for usefulness.
You are not required to respond to every AI comment, but they are intended to help both authors and reviewers.
Please react to Greptile comments with 👍 or 👎 to provide feedback on their accuracy.