Conversation
|
Hi @Ira-Shokar - As you may or may not be aware, our maintainer for curator has left and I'm stepping in for now. So I'll be your reviewer for this :) I haven't run the code yet - I will try to do so - but, I can see there is a good bit of duplication. Can we consolidate this to two folders instead of 4, and make sure there is minimal duplication of code? |
| raise ValueError(f"Failed to read CGNS file: {filepath}") | ||
|
|
||
| # Extract surface and triangulate | ||
| surface_mesh = original_mesh.extract_surface().triangulate() |
There was a problem hiding this comment.
Seems like this is tightly configured only for handling surface meshes. Volume mesh will not need extract_surface and triangulate methods.
| from physicsnemo_curator.etl.processing_config import ProcessingConfig | ||
|
|
||
|
|
||
| class CGNSDataSource(DataSource): |
There was a problem hiding this comment.
Seems like this class is common across several examples. Should this be moved into the curator source code? @coreyjadams @ram-cherukuri
| from physicsnemo_curator.etl.processing_config import ProcessingConfig | ||
|
|
||
|
|
||
| class CGNSToZarrTransformation(DataTransformation): |
There was a problem hiding this comment.
Please add support for global parameters like the domino example that @ns5678 has written
4 participants
These tutorial explain how to use PhysicsNeMo-Curator for preparing datasets from Ensight Gold and CGNS, detailing the ETL process, prerequisites, pipeline components, usage guide, output structure, and adaptation for real data files.