Updates for compatibility with PhysicsNeMo 2.0+#39
Merged
Conversation
…ity with PhysicsNeMo v2 - Clarified test skipping conditions in CONTRIBUTING.md for `compute_error_vs_sdf`. - Refactored `design_datapipe.py` to replace deprecated utility imports and introduced numpy wrappers for SDF and grid creation functions to maintain compatibility with the new torch-only implementations. - Updated `main.py` to reflect changes in utility imports.
Collaborator
Author
|
@abokov-nv for awareness, this closes NVBUGS 6188548 |
ktangsali
approved these changes
May 21, 2026
Collaborator
ktangsali
left a comment
ktangsali
left a comment
There was a problem hiding this comment.
LGTM. Quick question - why is this PR changing the uv.lock file? Is that because it was never updated?
Collaborator
Author
|
/blossom-ci |
Collaborator
Author
|
Also: this PR adds the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PhysicsNeMo-CFD Pull Request
Description
compute_error_vs_sdf.design_datapipe.pyto replace deprecated utility imports and introduced numpy wrappers for SDF and grid creation functions to maintain compatibility with the new torch-only implementations.main.pyto reflect changes in utility imports.Checklist
Dependencies