Merged
Conversation
- Architecture diagram listed /dev/shm but code mounts /run and /tmp - Dependency count was 9 but Cargo.toml has 7 direct dependencies - Removed reference to mount_parsing fuzz target that doesn't exist Signed-off-by: yardencuriel <splint_disk.8i@icloud.com>
zvonkok
approved these changes
Feb 24, 2026
Collaborator
zvonkok
left a comment
zvonkok
left a comment
There was a problem hiding this comment.
LGTM, thanks @YardenCuriel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-referenced the README against the source and found three inaccuracies:
Architecture diagram mount points
The diagram listed /dev/shm but mount.rs::setup_at() actually mounts /run (tmpfs) and /tmp (tmpfs). No /dev/shm mount exists in the codebase.
Dependency count
Security model section stated 9 direct dependencies but Cargo.toml lists 7: nix, cfg-if, log, kernlog, rlimit, libc, once_cell.
Non-existent fuzz target
Testing section referenced cargo +nightly fuzz run mount_parsing but only kernel_params exists in fuzz/fuzz_targets/ and fuzz/Cargo.toml.