fix(profiler): add ncclUint8 mapping#2032
Closed
pjo256 wants to merge 2 commits intoNVIDIA:masterfrom
Closed
Conversation
Signed-off-by: Philip Ottesen <phiott256@gmail.com>
Signed-off-by: Philip Ottesen <phiott256@gmail.com>
Author
|
Hi @stephenmsachs and @marksantesson - small PR to support uint8 in the v1 profiler, if you could take a look. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing
ncclUint8handling in the profiler and v1 adapter.Related Issues
Fixes #1764.
Changes & Impact
ncclDatatypeToString(ncclUint8)now returnsncclUint8instead ofUnknown"ncclUint8"toncclUint8 (value 1).Testing
I ran
nccl-tests all_reduce_perfwithuint8