examples: clean up unused members in context_t#1989
Closed
chenhengqi wants to merge 1 commit intoNVIDIA:masterfrom
Closed
examples: clean up unused members in context_t#1989chenhengqi wants to merge 1 commit intoNVIDIA:masterfrom
chenhengqi wants to merge 1 commit intoNVIDIA:masterfrom
Conversation
Collaborator
|
@chenhengqi can you update this to align with the new examples path, under |
Remove nccl_id, comm, nccl_unique_id and thread_ranks from context_t as they are no longer used. Clean up associated memory allocation and deallocation code. Signed-off-by: Hengqi Chen <hengqi.chen@gmail.com>
chenhengqi
force-pushed
the
refactor-examples
branch
from
8d89648 to
7069ca3
Compare
Contributor
Author
|
@teojgo done. |
Collaborator
|
/mirror |
Collaborator
|
@chenhengqi, this has been merged here 628c20a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove nccl_id, comm, nccl_unique_id and thread_ranks from context_t as they are no longer used. Clean up associated memory allocation and deallocation code.
Related Issues
N/A
Changes & Impact
N/A
Performance Impact
N/A