Correction for text with punctuation and dash#33
Open
hyunjoolee wants to merge 2 commits intoNVIDIA:masterfrom
Open
Correction for text with punctuation and dash#33hyunjoolee wants to merge 2 commits intoNVIDIA:masterfrom
hyunjoolee wants to merge 2 commits intoNVIDIA:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have found that if there are punctuation and dash characters in the text, they are not converted to clean text in text/init.py get_arpabet().
For examples, words like "recommendations.", "fbi," and "policy-making" are not searchable in the cmu_dict.
I think these will reduce model performance.
So I suggest some code as attached.