avoid unicode character that messes up pod rendering#2195
Open
rajatchopra wants to merge 1 commit intoNVIDIA:mainfrom
Open
avoid unicode character that messes up pod rendering#2195rajatchopra wants to merge 1 commit intoNVIDIA:mainfrom
rajatchopra wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
Contributor
Author
|
cc @jojimt |
rajathagasthya
approved these changes
Mar 6, 2026
Contributor
|
What about Line 49? Why is this issue only being discovered now? We have the same entrypoint scripts in the kubevirt-gpu-device-plugin and no one has reported issues. https://github.com/NVIDIA/gpu-operator/blob/main/assets/state-sandbox-device-plugin/0500_daemonset.yaml |
Contributor
|
Also note, based on the PR description I believe you intended to update https://github.com/NVIDIA/gpu-operator/blob/main/assets/state-kata-device-plugin/0500_daemonset.yaml? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the '<' character, the script is rendered like this:
if [ \"$(\u003c/run/nvidia/validations/workload-type)\" != \"vm-passthrough\" ]; then echo kata not needed, skipping validation; exit 0; fi;This PR changes the
<tocatso that the init check is functional.Checklist
make lint)make validate-generated-assets)make validate-modules)Testing
Manual out of band testing.