Skip to content

avoid unicode character that messes up pod rendering#2195

Open
rajatchopra wants to merge 1 commit intoNVIDIA:mainfrom
rajatchopra:renderfix
Open

avoid unicode character that messes up pod rendering#2195
rajatchopra wants to merge 1 commit intoNVIDIA:mainfrom
rajatchopra:renderfix

Conversation

@rajatchopra
Copy link
Contributor

Description

When using the '<' character, the script is rendered like this:
if [ \"$(\u003c/run/nvidia/validations/workload-type)\" != \"vm-passthrough\" ]; then echo kata not needed, skipping validation; exit 0; fi;

This PR changes the < to cat so that the init check is functional.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Manual out of band testing.

Signed-off-by: Rajat Chopra <rajatc@nvidia.com>
@rajatchopra
Copy link
Contributor Author

cc @jojimt

@cdesiniotis
Copy link
Contributor

What about Line 49? Why is this issue only being discovered now? We have the same entrypoint scripts in the kubevirt-gpu-device-plugin and no one has reported issues. https://github.com/NVIDIA/gpu-operator/blob/main/assets/state-sandbox-device-plugin/0500_daemonset.yaml

@cdesiniotis
Copy link
Contributor

Also note, based on the PR description I believe you intended to update https://github.com/NVIDIA/gpu-operator/blob/main/assets/state-kata-device-plugin/0500_daemonset.yaml?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants