Skip to content

Conversation

@rahulait
Copy link
Contributor

@rahulait rahulait commented Jan 12, 2026

Description

This PR adds additional nodefeaturerules which will label the node about the additional nvidia drivers installed on the node.
With nvidiaDriver CR, we would like to have the ability to target workloads to certain nodes which has the additional driver installed. This PR adds nodefeaturerules which will add labels to nodes based on the drivers status.

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Deployed a cluster with the following nfd rules and having gdrcopy and gds true. Here is the output of node labels after install:

k get node 2u2g-gen-0409 -o json | jq .metadata.labels | grep "gpu.driver."
  "nvidia.com/gpu-driver-upgrade-state": "upgrade-done",
  "nvidia.com/gdrcopy.capable": "true",
  "nvidia.com/gds.capable": "true",

@copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 12, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rahulait
Copy link
Contributor Author

/ok to test ab6e7b3

Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
@rahulait rahulait force-pushed the nfd-rules-for-additional-drivers branch from ab6e7b3 to ba224dc Compare January 13, 2026 18:59
@rahulait
Copy link
Contributor Author

/ok to test ba224dc

@tariq1890
Copy link
Contributor

Thanks @rahulait . @cdesiniotis Requesting your review on this

@tariq1890 tariq1890 merged commit a96a900 into NVIDIA:main Jan 15, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants