Consolidate e2e module by switching helm client to CLI and removing nested module #2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karthikvetrivel
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
karthikvetrivel
force-pushed
the
e2e-consolidate-module-shell-helm
branch
2 times, most recently
from
fd4aa72 to
ede4651
Compare
…ested module Signed-off-by: Karthik Vetrivel <kvetrivel@nvidia.com>
karthikvetrivel
force-pushed
the
e2e-consolidate-module-shell-helm
branch
from
ede4651 to
876e414
Compare
| return "", fmt.Errorf("error installing operator: %w: %s", err, stderr.String()) | ||
| } | ||
|
|
||
| releaseName, err := parseReleaseName(stdout.String()) |
Contributor
There was a problem hiding this comment.
We only need to parse release name from the output when we use --generate-name flag. Is there a need to use that option in tests? Can we just not generate a release name (with a random suffix or something) and use it everywhere?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This change eliminates the separate Go module at
tests/e2e/by:github.com/mittwald/go-helm-clientlibrary with directhelmbinary executionThis prevents Helm-related CVEs from being introduced into the GPU Operator images while fixing dependency drift issues.
Tested:
cd tests/e2e && go build ./...make unit-testmake validate-modulescd tests/e2e && make e2e-test