gpu-manager: enable kernel module configuration via KernelModuleConfig #512
+196
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivakunv
force-pushed
the
gpumanagerkernelmodulespec
branch
from
e901623 to
4736b16
Compare
shivakunv
force-pushed
the
gpumanagerkernelmodulespec
branch
from
4736b16 to
c3ca1e4
Compare
Contributor
shivakunv
force-pushed
the
gpumanagerkernelmodulespec
branch
from
c3ca1e4 to
800e42e
Compare
Signed-off-by: Shiva Kumar (SW-CLOUD) <shivaku@nvidia.com>
shivakunv
force-pushed
the
gpumanagerkernelmodulespec
branch
from
e4c606e to
6ba105b
Compare
Contributor
Author
cdesiniotis
reviewed
Jan 9, 2026
Comment on lines
+96
to
+107
| # Unload modules if they're already loaded so we can reload with custom parameters | ||
| if [ -f /sys/module/nvidia_vgpu_vfio/refcnt ] || [ -f /sys/module/nvidia/refcnt ]; then | ||
| echo "NVIDIA modules already loaded by installer, unloading to apply custom parameters..." | ||
| rmmod nvidia_vgpu_vfio 2>/dev/null || true | ||
| rmmod nvidia 2>/dev/null || true | ||
| fi | ||
|
|
||
| echo "Loading NVIDIA driver kernel modules..." | ||
| set -o xtrace +o nounset | ||
| modprobe nvidia | ||
| modprobe nvidia_vgpu_vfio | ||
| set +o xtrace -o nounset |
Contributor
There was a problem hiding this comment.
This change did not make sense to me at first. But then I realized that the _install_driver() actually loads the modules (we leverage the nvidia-installer to load the modules, in addition to building+installing the driver).
Question -- If we create the modprobe conf file (/etc/modprobe.d/nvidia.conf) BEFORE calling _install_driver(), what is the observed behavior? Do the modules get loaded with the desired parameters?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.