Additional Claude Skills#813
Closed
NickGeneva wants to merge 7 commits into
Closed
Conversation
Add two Claude skills for diagnostic model (dx) development: - create-diagnostic-wrapper: Steps 0-12 for wrapping both NN-based and physics-based diagnostic models with CONFIRM gates - validate-diagnostic-wrapper: Steps 1-4 for tests, reference comparison, sanity-check plots, PR submission, and Greptile review
Add validation skill for prognostic model (px) wrappers, mirroring the validate-diagnostic-wrapper pattern. Covers test coverage, single-step and multi-step reference comparison, forecast evolution plots, iterator validation, PR submission, and Greptile review.
Add two new Claude skills for data assimilation (DA) models: - create-assimilation-wrapper: Steps 0-8 for wrapping DA models with FrameSchema/CoordSystem, send-protocol generators, cupy/cudf support - validate-assimilation-wrapper: Steps 1-5 for tests, reference comparison, sanity-check plots, PR submission, Greptile review Includes spec and implementation plan documents.
Contributor
Greptile SummaryThis PR adds three new Claude skill pairs —
|
| Filename | Overview |
|---|---|
| .claude/skills/create-assimilation-wrapper/SKILL.md | New skill for creating DA model wrappers; well-structured with clear step ordering, canonical method template, and correct use of OUTPUT_VARIABLES throughout. No issues found. |
| .claude/skills/create-diagnostic-wrapper/SKILL.md | New skill for DX model wrappers; physics-based skeleton has a mutable default argument (levels: list = [100]) that should use None sentinel instead. |
| .claude/skills/validate-assimilation-wrapper/SKILL.md | New validation skill for DA wrappers; coverage command now correctly uses --package (previous thread fix applied), but PhooModelName has an ambiguous dual-role that may mislead agents generating tests. |
| .claude/skills/validate-diagnostic-wrapper/SKILL.md | New validation skill for DX wrappers; complete workflow with reference comparison, sanity-check plots, PR creation, and Greptile review loop. No issues found. |
| .claude/skills/validate-prognostic-wrapper/SKILL.md | New validation skill for PX wrappers; covers single-step and multi-step comparison, iterator validation, and PR workflow. No issues found. |
| docs/userguide/developer/agents.md | New developer documentation page describing all create/validate skill pairs; accurately reflects the skills added in this PR and existing create-prognostic-wrapper/create-data-source skills. |
Reviews (2): Last reviewed commit: "Greptile" | Re-trigger Greptile
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Collaborator
Author
Collaborator
Author
|
Closing, out of date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earth2Studio Pull Request
Description
Adding some additional claude skills for model wrappers.
Checklist
Dependencies