Skip to content

Disable support for calling kernels defined in Python from kernels defined in C++#411

Closed
sacpis wants to merge 26 commits intoNVIDIA:mainfrom
sacpis:disable_support_for_calling_kernels_in_python
Closed

Disable support for calling kernels defined in Python from kernels defined in C++#411
sacpis wants to merge 26 commits intoNVIDIA:mainfrom
sacpis:disable_support_for_calling_kernels_in_python

Conversation

@sacpis
Copy link
Copy Markdown
Collaborator

@sacpis sacpis commented Jan 17, 2026

Disable support for calling kernels defined in Python from kernels defined in C++.

Note: This branch (PR) builds against features/python.redesign.0 branch in CUDA-Q.

sacpis added 2 commits January 16, 2026 17:56
@sacpis
Adding patch for MLIR/LLVM and disabling tests which uses extract_c_f…
9bfdf35 
…unction_pointer from cudaq

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
disabling py-surface_code-1-test as it uses get_code
cbc5046 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jan 17, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@sacpis
format
e37bac1 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Copy link
Copy Markdown
Collaborator Author

sacpis commented Jan 17, 2026

/ok to test e37bac1

@bmhowe23
Copy link
Copy Markdown
Collaborator

bmhowe23 commented Jan 20, 2026

/ok to test e37bac1

sacpis added 5 commits January 20, 2026 15:40
@sacpis
disabling few more tests in qec
80a5155 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
updating cudaq version from features/python.redesign.0 branch
d7673c0 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
disable example
097cb21 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
disable example
bd74218 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
disable few more tests
de24de8 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@bmhowe23
Copy link
Copy Markdown
Collaborator

bmhowe23 commented Jan 21, 2026

/ok to test de24de8

bmhowe23
bmhowe23 reviewed Jan 21, 2026
View reviewed changes
Comment thread .cudaq_version
"cudaq": {
"repository": "NVIDIA/cuda-quantum",
"ref": "c4131f47cf236a7694cf6d5b8ff3418933817749"
"ref": "35054a5bae85129e422c589023a5b30ce32d24c2"
Copy link
Copy Markdown
Collaborator

@bmhowe23 bmhowe23 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note - we will want to revert this change, or at least update it to a commit on main, before merging this PR.

Copy link
Copy Markdown
Collaborator Author

@sacpis sacpis Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we will have to update it now itself as the jobs are failing in CI.

Copy link
Copy Markdown
Collaborator

@bmhowe23 bmhowe23 Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are updating it to tot main, then are the rest of the changes in the PR needed? I thought tot main would work without any other changes.

Copy link
Copy Markdown
Collaborator Author

@sacpis sacpis Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. Let me put it back. Seems like cudaq/utils/registry.h file has been removed from CUDA-Q repo. Cleaning this irrelevant header file from py_code.

@sacpis
updating cudaq version to tot main
e2906e4 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Copy link
Copy Markdown
Collaborator Author

sacpis commented Jan 21, 2026

/ok to test e2906e4

@sacpis
fix the file path and cudaq version
60ab13a 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Copy link
Copy Markdown
Collaborator Author

sacpis commented Jan 21, 2026

/ok to test 60ab13a

@sacpis
adding LLVM?MLIR dependency to qec and solvers as well
feea0c4 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Copy link
Copy Markdown
Collaborator Author

sacpis commented Jan 21, 2026

/ok to test feea0c4

@sacpis
skipping examples
1cfd5d8 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Copy link
Copy Markdown
Collaborator Author

sacpis commented Jan 21, 2026

/ok to test 1cfd5d8

sacpis added 9 commits January 21, 2026 10:14
@sacpis
Adding patch for MLIR/LLVM and disabling tests which uses extract_c_f…
3c40137 
…unction_pointer from cudaq

Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
disabling py-surface_code-1-test as it uses get_code
83c6da0 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
format
e7cc491 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
disabling few more tests in qec
88449e6 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
updating cudaq version from features/python.redesign.0 branch
cc5ab43 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
disable example
89b2611 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
disable example
84dae81 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
disable few more tests
449a064 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
updating cudaq version to tot main
87661ad 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
sacpis added 5 commits January 21, 2026 10:15
@sacpis
fix the file path and cudaq version
e98bddf 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
adding LLVM?MLIR dependency to qec and solvers as well
4b40bc4 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
skipping examples
9207172 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Merge branch 'disable_support_for_calling_kernels_in_python' of https…
6c6c13c 
…://github.com/sacpis/cudaqx into disable_support_for_calling_kernels_in_python
@sacpis
Merge branch 'main' into disable_support_for_calling_kernels_in_python
9946dff 
Signed-off-by: Sachin Pisal <spisal@nvidia.com>
@sacpis
Copy link
Copy Markdown
Collaborator Author

sacpis commented Jan 21, 2026 •
edited
Loading

/ok to test 9946dff

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented Jan 21, 2026

/ok to test 6c6c13c

@sacpis, there was an error processing your request: E2

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/

@sacpis
Copy link
Copy Markdown
Collaborator Author

sacpis commented Jan 21, 2026

/ok to test 9946dff

@bmhowe23
Copy link
Copy Markdown
Collaborator

bmhowe23 commented Feb 12, 2026

This was absorbed into #416, so I'm closing this PR.

@bmhowe23 bmhowe23 closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmhowe23 bmhowe23 bmhowe23 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sacpis @bmhowe23