Exclude broken cuda-toolkit wheels on Windows#1884
Open
rwgk wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
Made-with: Cursor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cuda-toolkit 12.9.2and13.0.3only on Windows incuda_pathfinder,cuda_core, andcuda_bindings12.*and13.*behavior on Linux, since the Linux matrix did not show the same breakageBackground
During CI for PR #1817, a group of Windows test jobs started failing in
cuda.pathfinderstrict mode after newcuda-toolkitpatch releases became available on the package index.Compared with the last successful CI run against
main, the affected Windows jobs changed from resolving:cuda-toolkit 12.9.1to12.9.2cuda-toolkit 13.0.2to13.0.3Those failing Windows jobs then stopped installing the full set of CTK DLL-providing packages such as
cublas,cufft,curand,cusolver,cusparse,npp, andnvjpeg, andcuda.pathfinderstrict checks failed as a result.The strongest current hypothesis is that these two newly published
cuda-toolkitpatch releases have broken Windows dependency metadata for extras resolution. Linux did not show the same regression.What This PR Changes
cuda_pathfindercu12andcu13toolkit requirements by platform12.9.2and13.0.3only whensys_platform == 'win32'12.*/13.*rangescuda_coretest-cu12,test-cu13,test-cu12-ft, andtest-cu13-ftcuda_bindingsallextra for the toolkit packages it installsWhy Windows-Only
The exclusion-based workaround was first applied uniformly (Linux & Windows) under #1817. That is a significantly simpler change, but strictly speaking the observed breakage is Windows-specific:
cuda.pathfinderjobs were Windows jobs12.*/13.*specs continued to passRestricting the exclusions to Windows makes the workaround narrower and keeps Linux on the normal floating-major behavior.