Adding function for MPI communicators in Fortran integer format to simplify Fortran interfaces. #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mplify Fortran interfaces. Signed-off-by: Josh Romero <joshr@nvidia.com>
Signed-off-by: Josh Romero <joshr@nvidia.com>
Collaborator
Author
|
/build |
|
🚀 Build workflow triggered! View run |
|
✅ Build workflow passed! View run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reusing an idea from another library I maintain (see: NVIDIA/TorchFort#81).
This PR adds a cuDecomp initialization function (
cudecompInit_F) in C/C++ that takes anMPI_Fintfor the MPI communicator. The reasoning for this is thatMPI_Commis not consistently defined across MPI implementations and introduces ABI compatibility issues.These new functions also enable us to simplify the current Fortran MPI communicator handling in our interfaces, removing any need to convert Fortran MPI communicators to their C counterparts. A secondary benefit is that this also removes all the special case handling for MPICH, which does not have a
MPI_Comm_f2cfunction available.