Fix double-precision version of builder#17
Merged
iwald-nvidia merged 6 commits intoNVIDIA:mainfrom Jan 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, cuBQL's default gpu builder always used single precision floats for finding the split position, even if input data was doubles. Since tree was eventually properly refit with doubles afterwards the trees were still correct (arguably why this wasn't found earlier), but this is still not as it was supposed to be. This patch fixes the 'AtomicBox<>' template to be properly specialized for ints, longlongs, and doubles.