Open
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
9c7d191 to
70d72f8
Compare
70d72f8 to
eeadf01
Compare
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
eeadf01 to
ebe0f0c
Compare
Signed-off-by: Peter St. John <pstjohn@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes changes from #1486, if we merge that the diff here will just be in
qwen3.Includes a temporary fix for NVIDIA/TransformerEngine#2718, which we can remove when that is merged and in the base image.
This adds the Qwen3 model (https://huggingface.co/Qwen/Qwen3-0.6B), specifically the dense variant, although MoE would be fairly easy to add with our Mixtral model recipe.
Key differences of Qwen3 vs. Llama3 --
qk_norm_typeandqk_norm_before_ropekwargswindow_sizekwarg on certain layers: