Skip to content

[None][fix] Update CUTLASS C++ to 4.4.2#12897

Open
depaulmillz wants to merge 1 commit intoNVIDIA:mainfrom
depaulmillz:update_cutlass
Open

[None][fix] Update CUTLASS C++ to 4.4.2#12897
depaulmillz wants to merge 1 commit intoNVIDIA:mainfrom
depaulmillz:update_cutlass

Conversation

@depaulmillz
Copy link
Copy Markdown

@depaulmillz depaulmillz commented Apr 9, 2026

Summary by CodeRabbit

  • Chores
    • Updated cutlass dependency to v4.4.2

Description

CUTLASS 4.4.2 fixed an auto smem carveout issue for SM12x which resulted in some group GEMM launch failures. This MR updates CUTLASS C++ from 4.4.1 to 4.4.2 in order to get the fix. This should ensure that prior kernel launches that were failing on SM12x with 4.4.1 will be fixed.

Test Coverage

N/A

PR Checklist

Please review the following before submitting your PR:

  • PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.

  • PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.

  • Test cases are provided for new code paths (see test instructions)

  • Any new dependencies have been scanned for license and vulnerabilities

  • CODEOWNERS updated if ownership changes

  • Documentation updated as needed

  • Update tava architecture diagram if there is a significant design change in PR.

  • The reviewers assigned automatically/manually are appropriate for the PR.

  • [ x] Please check this after reviewing the above items as appropriate for this PR.

GitHub Bot Help

To see a list of available CI bot commands, please comment /bot help.

@depaulmillz depaulmillz requested a review from a team as a code owner April 9, 2026 17:45
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

📝 Walkthrough

Walkthrough

Updated the cutlass dependency version from v4.4.1 to v4.4.2 in the fetch content configuration file. All other repository settings and fetch parameters remain unchanged.

Changes

Cohort / File(s) Summary
Dependency Update
3rdparty/fetch_content.json
Bumped cutlass git tag from v4.4.1 to v4.4.2; all other fetch configuration settings preserved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The PR description includes a clear explanation of the issue (auto smem carveout bug on SM12x) and the solution (upgrading to 4.4.2), though Test Coverage and some checklist items are minimal or incomplete.
Title check ✅ Passed The title clearly and accurately summarizes the main change: updating CUTLASS C++ from version 4.4.1 to 4.4.2.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
3rdparty/fetch_content.json (1)

14-14: Pin to commit SHA for reproducibility and verify alignment with SM12x carveout fix.

The tag v4.4.2 resolves to commit da5e086dab31d63815acafdac9a9c5893b1c69e2. Pinning to the commit SHA instead of the tag hardens reproducibility and supply-chain resilience. Note that the release notes do not explicitly mention the SM12x shared-memory carveout group GEMM fix stated in the PR objective—confirm this tag addresses the intended issue.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@3rdparty/fetch_content.json` at line 14, Replace the "git_tag" pin with the
exact commit SHA da5e086dab31d63815acafdac9a9c5893b1c69e2 in fetch_content.json
(replace the "git_tag" value with this SHA) to ensure reproducible fetches, and
then verify the checked-out commit contains the SM12x shared-memory carveout
GEMM fix by inspecting the commit diff/PR referenced in that commit to confirm
it matches the intended fix before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@3rdparty/fetch_content.json`:
- Line 14: Replace the "git_tag" pin with the exact commit SHA
da5e086dab31d63815acafdac9a9c5893b1c69e2 in fetch_content.json (replace the
"git_tag" value with this SHA) to ensure reproducible fetches, and then verify
the checked-out commit contains the SM12x shared-memory carveout GEMM fix by
inspecting the commit diff/PR referenced in that commit to confirm it matches
the intended fix before merging.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f752def2-bb46-4a8e-b180-7cada48f7a25

📥 Commits

Reviewing files that changed from the base of the PR and between 1936367 and b276e64.

📒 Files selected for processing (1)
  • 3rdparty/fetch_content.json

@depaulmillz depaulmillz changed the title Update CUTLASS C++ to 4.4.2 [none][fix] Update CUTLASS C++ to 4.4.2 Apr 9, 2026
@depaulmillz depaulmillz changed the title [none][fix] Update CUTLASS C++ to 4.4.2 [None][fix] Update CUTLASS C++ to 4.4.2 Apr 9, 2026
@pamelap-nvidia
Copy link
Copy Markdown
Collaborator

/bot run

@tensorrt-cicd
Copy link
Copy Markdown
Collaborator

PR_Github #42564 [ run ] triggered by Bot. Commit: b276e64 Link to invocation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants