[None][fix] Update moe hidden_size in communicator for nemotron-h#12890
[None][fix] Update moe hidden_size in communicator for nemotron-h#12890Wanli-Jiang wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Signed-off-by: Wanli Jiang <35160485+Wanli-Jiang@users.noreply.github.com>
|
/bot run --add-multi-gpu-test --disable-fail-fast |
📝 WalkthroughWalkthroughThis PR adds an optional Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tensorrt_llm/_torch/modules/fused_moe/communication/communication_factory.py (1)
1-1:⚠️ Potential issue | 🟡 MinorUpdate copyright year for this modified file.
This file was modified in 2026, but the SPDX copyright line still says 2025.
Suggested fix
-# SPDX-FileCopyrightText: Copyright (c) 2025 NVIDIA CORPORATION & AFFILIATES. All rights reserved. +# SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved.As per coding guidelines: “All TensorRT-LLM Open Source Software code files should contain an NVIDIA copyright header with the year of latest meaningful modification” and “Include NVIDIA copyright header on ALL new files (update year on modified files)”.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tensorrt_llm/_torch/modules/fused_moe/communication/communication_factory.py` at line 1, Update the SPDX copyright header in tensorrt_llm/_torch/modules/fused_moe/communication/communication_factory.py to reflect the latest modification year (change 2025 to 2026) so the NVIDIA copyright line matches the file's most recent meaningful modification.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In
`@tensorrt_llm/_torch/modules/fused_moe/communication/communication_factory.py`:
- Line 1: Update the SPDX copyright header in
tensorrt_llm/_torch/modules/fused_moe/communication/communication_factory.py to
reflect the latest modification year (change 2025 to 2026) so the NVIDIA
copyright line matches the file's most recent meaningful modification.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: cd568bca-cd12-4207-8da8-b826e7b874ce
📒 Files selected for processing (2)
tensorrt_llm/_torch/modules/fused_moe/communication/communication_factory.pytensorrt_llm/_torch/modules/fused_moe/configurable_moe.py
|
PR_Github #42528 [ run ] triggered by Bot. Commit: |
|
PR_Github #42528 [ run ] completed with state
|
|
/bot run --add-multi-gpu-test --disable-fail-fast |
|
PR_Github #42602 [ run ] triggered by Bot. Commit: |
Summary by CodeRabbit
Description
Test Coverage
PR Checklist
Please review the following before submitting your PR:
PR description clearly explains what and why. If using CodeRabbit's summary, please make sure it makes sense.
PR Follows TRT-LLM CODING GUIDELINES to the best of your knowledge.
Test cases are provided for new code paths (see test instructions)
Any new dependencies have been scanned for license and vulnerabilities
CODEOWNERS updated if ownership changes
Documentation updated as needed
Update tava architecture diagram if there is a significant design change in PR.
The reviewers assigned automatically/manually are appropriate for the PR.
Please check this after reviewing the above items as appropriate for this PR.
GitHub Bot Help
To see a list of available CI bot commands, please comment
/bot help.