Skip to content

fix(onboard): restore messaging skip hint#4526

Merged
jyaunches merged 1 commit into
NVIDIA:mainfrom
rluo8:fix/4427-messaging-skip-hint-regressed
May 29, 2026
Merged

fix(onboard): restore messaging skip hint#4526
jyaunches merged 1 commit into
NVIDIA:mainfrom
rluo8:fix/4427-messaging-skip-hint-regressed

Conversation

@rluo8
Copy link
Copy Markdown
Contributor

@rluo8 rluo8 commented May 29, 2026

Summary

Restore the missing “none selected skips” hint in the interactive messaging channel picker. The skip behavior already worked; this makes the prompt discoverable again for users. The hit was originally added in #4026 and was removed in later refactor PR.

Related Issue

Fixes #4427

Changes

Updated the messaging channel picker prompt to include (none selected skips).

Type of Change

  • [√ ] Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • [√ ] npx prek run --all-files passes
  • [ √] npm test passes
  • Tests added or updated for new or changed behavior
  • [ √] No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: rluo8 ruluo@nvidia.com

Summary by CodeRabbit

  • Chores
    • Updated the messaging channels selection prompt text in the onboarding flow to clarify that leaving no channels selected and pressing Enter will skip that step.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 32411556-757b-4f5b-8fb5-07f5223107a7

📥 Commits

Reviewing files that changed from the base of the PR and between faa0b8e and ec2c695.

📒 Files selected for processing (1)
  • src/lib/onboard.ts

📝 Walkthrough

Walkthrough

This PR updates the messaging-channel selection prompt in the onboard flow to explicitly state that pressing Enter with no channels selected will skip the messaging setup, making the existing skip behavior discoverable to users.

Changes

Messaging Channel Prompt Clarification

Layer / File(s) Summary
Messaging channel skip hint
src/lib/onboard.ts
Updated the prompt text to include "(none selected skips)" hint, clarifying that pressing Enter without selecting any channel will skip messaging-channel configuration. No selection logic or behavior changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • NVIDIA/NemoClaw#4026: Earlier PR updating the same messaging-channels interactive prompt text with the same clarification hint.

Suggested labels

NemoClaw CLI, enhancement: ui, fix

Poem

🐰 A prompt whispers clear as the moon,
"Press none, then Enter, skip this tune!"
The hint emerges, users rejoice,
The path they seek now has a voice! 🌙

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(onboard): restore messaging skip hint' directly and accurately describes the main change: restoring the missing skip hint in the messaging channel prompt.
Linked Issues check ✅ Passed The PR successfully addresses issue #4427 by restoring the '(none selected skips)' hint to the messaging channel selector prompt, enabling users to discover the skip-by-Enter behavior as required.
Out of Scope Changes check ✅ Passed The PR contains only one line change in src/lib/onboard.ts focused on updating the prompt text, which is directly within scope of restoring the messaging skip hint as specified in issue #4427.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.


Comment @coderabbitai help to get the list of available commands and usage tips.

@rluo8 rluo8 added the v0.0.55 label May 29, 2026
@wscurran wscurran added the fix label May 29, 2026
@wscurran
Copy link
Copy Markdown
Contributor

@jyaunches jyaunches self-requested a review May 29, 2026 17:45
Copy link
Copy Markdown
Contributor

@jyaunches jyaunches left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial UX fix: restores the '(none selected skips)' hint in the messaging channel picker that regressed after #4026. One-line string change, no logic touched, all CI green, no advisor or CodeRabbit findings. LGTM.

@jyaunches jyaunches merged commit 75aa9a8 into NVIDIA:main May 29, 2026
31 checks passed
miyoungc added a commit that referenced this pull request May 29, 2026
## Summary
Promotes NemoClaw user skills in the most visible docs entry points and
refreshes the docs for v0.0.55.
This keeps the public docs and generated user skills aligned with the
latest release tag.

## Related Issue
None.

## Changes
- Adds homepage, overview, prerequisites, and quickstart links that make
NemoClaw user skills easier to discover.
- #4540 -> `docs/inference/use-local-inference.mdx` and
`docs/about/release-notes.mdx`: Documents local Ollama validation
retries and Docker runtime detection retries.
- #4519 -> `docs/about/release-notes.mdx`: Notes the plugin
secret-scanner fallback behavior for embedded fallback mode.
- #4526 -> `docs/get-started/quickstart.mdx`,
`docs/manage-sandboxes/messaging-channels.mdx`, and
`docs/about/release-notes.mdx`: Documents that pressing Enter with no
messaging channels selected skips setup.
- Refreshes generated `nemoclaw-user-*` skills from the updated Fern
docs.

## Type of Change
- [ ] Code change (feature, bug fix, or refactor)
- [ ] Code change with doc updates
- [x] Doc only (prose changes, no code sample modifications)
- [ ] Doc only (includes code sample changes)

## Verification
- [ ] `npx prek run --all-files` passes
- [ ] `npm test` passes
- [ ] Tests added or updated for new or changed behavior
- [x] No secrets, API keys, or credentials committed
- [x] Docs updated for user-facing behavior changes
- [ ] `npm run docs` builds without warnings (doc changes only)
- [x] Doc pages follow the [style
guide](https://github.com/NVIDIA/NemoClaw/blob/main/docs/CONTRIBUTING.md)
(doc changes only)
- [ ] New doc pages include SPDX header and frontmatter (new pages only)

Verification details:
- `python3 scripts/docs-to-skills.py docs/ .agents/skills/ --prefix
nemoclaw-user --doc-platform fern-mdx` passed.
- `npm run docs` passed with 0 errors and the existing Fern light-mode
contrast warning.
- Commit hooks passed for the docs commits.
- Full all-files/pre-push checks were attempted but hit unrelated CLI
test timeouts, so the all-files checkbox is left unchecked.

---
Signed-off-by: Miyoung Choi <miyoungc@nvidia.com>

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Documentation**
* Added Agent Skills guidance and links across overview, getting
started, quickstart, and homepage to load NemoClaw user skills into AI
coding assistants.
* Clarified local inference onboarding reliability (retry/timeout
behavior and Docker detection) for Ollama/vLLM.
* Clarified messaging-channel onboarding to skip setup when no channels
are selected and Enter is pressed.
* Improved secret-scanner behavior descriptions and added v0.0.55
release notes.

<!-- review_stack_entry_start -->

[![Review Change
Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/NVIDIA/NemoClaw/pull/4547?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)

<!-- review_stack_entry_end -->

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@rluo8 rluo8 deleted the fix/4427-messaging-skip-hint-regressed branch June 1, 2026 04:57
@wscurran wscurran added bug-fix PR fixes a bug or regression and removed fix labels Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug-fix PR fixes a bug or regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Ubuntu 24.04][Onboard] Messaging channel prompt omits none-selected skip hint

3 participants