Skip to content

chore: skills signing batch 5#4466

Merged
miyoungc merged 2 commits into
mainfrom
skills-sign-batch-5
May 28, 2026
Merged

chore: skills signing batch 5#4466
miyoungc merged 2 commits into
mainfrom
skills-sign-batch-5

Conversation

@miyoungc
Copy link
Copy Markdown
Collaborator

@miyoungc miyoungc commented May 28, 2026

Summary

Related Issue

Changes

Type of Change

  • Code change (feature, bug fix, or refactor)
  • Code change with doc updates
  • Doc only (prose changes, no code sample modifications)
  • Doc only (includes code sample changes)

Verification

  • npx prek run --all-files passes
  • npm test passes
  • Tests added or updated for new or changed behavior
  • No secrets, API keys, or credentials committed
  • Docs updated for user-facing behavior changes
  • npm run docs builds without warnings (doc changes only)
  • Doc pages follow the style guide (doc changes only)
  • New doc pages include SPDX header and frontmatter (new pages only)

Signed-off-by: Your Name your-email@example.com

Summary by CodeRabbit

  • Documentation

    • Added comprehensive NemoClaw user guides (ecosystem, architecture, CLI selection, commands, network policies, troubleshooting) plus release notes.
    • Added two new skill packages with SKILL cards, reference docs, evaluation cases, benchmark reports, and signature artifacts.
  • Chores

    • Simplified evaluation datasets: removed detailed expected_behavior arrays and updated ground_truth entries for multiple evals to streamline testing.

Review Change Stack

@miyoungc
Copy link
Copy Markdown
Collaborator Author

/nvskills-ci

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

📝 Walkthrough

Walkthrough

Adds two new skills with comprehensive documentation and eval datasets (overview and reference), plus simplifies multiple existing eval JSON files by removing expected_behavior arrays and consolidating ground_truth.

Changes

Evaluation Dataset Schema Simplification

Layer / File(s) Summary
Legacy skill evals simplified
.agents/skills/nemoclaw-user-agent-skills/evals/evals.json, .agents/skills/nemoclaw-user-get-started/evals/evals.json, .agents/skills/nemoclaw-user-overview/evals/evals.json, .agents/skills/nemoclaw-user-reference/evals/evals.json
Removed expected_behavior arrays from existing eval objects; each entry now contains only id, question, expected_skill, and ground_truth.

NemoClaw User Overview Skill

Layer / File(s) Summary
Overview skill definition and evals
skills/nemoclaw-user-overview/SKILL.md, skills/nemoclaw-user-overview/evals/evals.json, skills/nemoclaw-user-overview/references/ecosystem.md
Adds skill metadata, evaluation cases, and an ecosystem reference describing NemoClaw's positioning relative to OpenShell/OpenClaw.
Architecture, overview, release-notes
skills/nemoclaw-user-overview/references/how-it-works.md, skills/nemoclaw-user-overview/references/overview.md, skills/nemoclaw-user-overview/references/release-notes.md, skills/nemoclaw-user-overview/BENCHMARK.md, skills/nemoclaw-user-overview/skill-card.md, skills/nemoclaw-user-overview/skill.oms.sig
Adds architecture narrative, how-it-works, overview, full release notes history, benchmark report, skill card, and DSSE signature for the overview skill.

NemoClaw User Reference Skill

Layer / File(s) Summary
Reference skill definition and evals
skills/nemoclaw-user-reference/SKILL.md, skills/nemoclaw-user-reference/evals/evals.json, skills/nemoclaw-user-reference/BENCHMARK.md
Adds skill metadata, evaluation cases, and benchmark report for the reference skill.
Architecture details reference
skills/nemoclaw-user-reference/references/architecture.md
Comprehensive architecture reference with system diagram, deployment topology, plugin/blueprint lifecycle, sandbox environment, inference routing, credential handling, and host-side config.
CLI selection and command reference
skills/nemoclaw-user-reference/references/cli-selection-guide.md, skills/nemoclaw-user-reference/references/commands.md, skills/nemoclaw-user-reference/references/network-policies.md
Decision guide for nemoclaw vs openshell, extensive command reference covering all CLI operations/options/flags, and network policy documentation.
Comprehensive troubleshooting guide
skills/nemoclaw-user-reference/references/troubleshooting.md
Full troubleshooting organized by Installation, Onboarding, Runtime, and environment-specific sections (DGX Spark, Windows/WSL, Podman, Brev) with diagnostics and remediation steps.
Skill artifacts
skills/nemoclaw-user-reference/skill-card.md, skills/nemoclaw-user-reference/skill.oms.sig
Adds skill-card and DSSE signature for the reference skill.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • NVIDIA/NemoClaw#4405: Related changes to eval generation and expected_behavior handling that overlap with these eval simplifications.
  • NVIDIA/NemoClaw#4360: Overlapping edits to skills/nemoclaw-user-overview/references/release-notes.md and related docs.

Suggested labels

enhancement: skill

Suggested reviewers

  • cv
  • ericksoa
  • jyaunches

Poem

🐰 Two new skills hop into the warren,
Docs and evals tidy, with guidance to borrow—
Ecosystem maps and CLI trails bright,
Troubleshooting lamps for the long night,
A rabbit's cheer for docs done right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: skills signing batch 5' is directly related to the changeset, which primarily adds skill definition files, evaluation data, reference documentation, and signature files for the nemoclaw-user-overview and nemoclaw-user-reference skills as part of a batch skills-signing effort.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch skills-sign-batch-5

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

E2E Advisor Recommendation

Required E2E: None
Optional E2E: docs-validation-e2e, skill-agent-e2e

Dispatch hint: docs-validation-e2e,skill-agent-e2e

Workflow run

Full advisor summary

E2E Recommendation Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required E2E

  • None. No required NemoClaw E2E is recommended because this PR only changes skill documentation, skill packaging metadata/signatures, benchmark reports, images, and eval JSON. It does not modify installer/onboarding code, sandbox lifecycle, credentials, network policy enforcement, inference routing, deployment logic, or runtime assistant implementation paths.

Optional E2E

  • docs-validation-e2e (low): Optional confidence for markdown/link hygiene after adding a large set of skill reference markdown files. It is not merge-blocking because the changes do not alter the installed CLI or runtime behavior.
  • skill-agent-e2e (medium): Optional broad smoke test that NemoClaw can inject a skill into a sandbox and have an agent read it. This does not specifically validate the newly added overview/reference skills, so it is useful only as adjacent confidence, not required.

New E2E recommendations

  • NVSkills publication and discoverability (medium): Existing NemoClaw E2E has a generic skill-agent fixture smoke, but no E2E job appears to validate that repository skills under skills/nemoclaw-user-* are packageable, discoverable, signature-consistent, and answer representative prompts using their own references/evals.
    • Suggested test: Add a skill-catalog-publication-e2e job that runs NVSkills validation for changed skills, verifies SKILL.md/reference links, validates eval schema compatibility, and checks that the expected skill is selected for representative overview/reference prompts.

Dispatch hint

  • Workflow: nightly-e2e.yaml
  • jobs input: docs-validation-e2e,skill-agent-e2e

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

E2E Scenario Advisor Recommendation

Required scenario E2E: None
Optional scenario E2E: None

Workflow run

Full scenario advisor summary

E2E Scenario Advisor

Base: origin/main
Head: HEAD
Confidence: high

Required scenario E2E

  • None. No scenario workflow, scenario metadata, scenario runtime, or validation-suite files changed.

Optional scenario E2E

  • None.

Relevant changed files

  • None.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 28, 2026

PR Review Advisor

Findings: 1 needs attention, 5 worth checking, 0 nice ideas
Since last review: 1 prior item resolved, 3 still apply, 2 new items found

Review findings

🛠️ Needs attention

  • Resolve failed benchmarks before publishing the signed skills (skills/nemoclaw-user-overview/BENCHMARK.md:12): Both newly published root catalog skills include signed catalog artifacts, but their committed benchmark reports still say the overall verdict is FAIL and recommend addressing findings before NVSkills-Eval publication. That conflicts with the catalog-publication intent and with the generated skill cards saying the skills are ready for use.
    • Recommendation: Address the benchmark findings or regenerate the benchmark reports after a passing publication evaluation before treating these root `skills/` packages as ready for catalog publication. If FAIL is expected for this signing batch, document that exception in the committed artifact so the publication state is not contradictory.
    • Evidence: `skills/nemoclaw-user-overview/BENCHMARK.md:12` and `skills/nemoclaw-user-reference/BENCHMARK.md:12` say `Overall verdict: FAIL`; `skills/nemoclaw-user-overview/BENCHMARK.md:68` and `skills/nemoclaw-user-reference/BENCHMARK.md:72` say the skill owners should address findings and rerun NVSkills-Eval before publication. The corresponding `skill-card.md` files say the skills are ready for commercial/non-commercial use.

🔎 Worth checking

  • Source-of-truth review needed: Generated user-skill eval schema simplification: The advisor marked localized patch analysis as needs_followup.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: The PR removes `expected_behavior` arrays from four `.agents/skills/nemoclaw-user-*` eval files while sibling user-skill evals still retain that field.
  • Ground-truth-only evals drop structured behavior checks (.agents/skills/nemoclaw-user-overview/evals/evals.json:1): The PR removes every `expected_behavior` array from four source eval files and publishes root evals that only keep `ground_truth`. Sibling NemoClaw user-skill evals still use `expected_behavior` to assert the assistant loads the expected skill/reference, avoids unsupported NemoClaw behavior, and follows progressive disclosure. These checks matter for security-sensitive installation, policy, inference, and operations guidance.
    • Recommendation: Either preserve the `expected_behavior` arrays for these evals, or include the evaluator/schema update and fixture evidence showing that the simplified `ground_truth`-only format still enforces the removed behaviors.
    • Evidence: The diff removes `expected_behavior` from `.agents/skills/nemoclaw-user-agent-skills/evals/evals.json`, `.agents/skills/nemoclaw-user-get-started/evals/evals.json`, `.agents/skills/nemoclaw-user-overview/evals/evals.json`, and `.agents/skills/nemoclaw-user-reference/evals/evals.json`. Repository siblings such as `.agents/skills/nemoclaw-user-deploy-remote/evals/evals.json`, `.agents/skills/nemoclaw-user-manage-policy/evals/evals.json`, and `.agents/skills/nemoclaw-user-configure-security/evals/evals.json` still contain those structured assertions.
  • Remote bind examples need explicit network-exposure controls (skills/nemoclaw-user-reference/references/commands.md:1199): The published skill documents `NEMOCLAW_GATEWAY_BIND_ADDRESS=0.0.0.0` and `NEMOCLAW_DASHBOARD_BIND=0.0.0.0`. The current text notes that services may become reachable and that non-loopback origins are accepted for dashboard auth, but these command snippets are likely to be surfaced directly by AI assistants and should carry a hard warning about trusted networks and access controls.
    • Recommendation: Add a short, hard-to-miss warning near the environment table and the `0.0.0.0` examples stating that remote binding exposes the gateway/dashboard beyond loopback and should only be used behind explicit controls such as firewall rules, VPN, or SSH tunneling, and not on public or untrusted LAN interfaces.
    • Evidence: `skills/nemoclaw-user-reference/references/commands.md:1199` lists `NEMOCLAW_GATEWAY_BIND_ADDRESS` as accepting `0.0.0.0`; `commands.md:1204` documents `NEMOCLAW_DASHBOARD_BIND`; `commands.md:1212-1218` says remote bind may make services reachable and dashboard auth accepts non-loopback origins; `commands.md:1226` and `skills/nemoclaw-user-reference/references/troubleshooting.md:208` show direct `0.0.0.0` examples.
  • Clarify Slack token wording so it does not imply raw secrets enter the sandbox (skills/nemoclaw-user-reference/references/commands.md:163): The command reference says the Slack app-level token is stored in an OpenShell provider and `forwarded to the sandbox alongside the bot token`. That wording conflicts with the architecture reference, which says raw credentials are never passed directly to the sandbox and that the sandbox receives placeholders. For a credential-handling guide, this ambiguity can lead users or agents to accept an unsafe mental model.
    • Recommendation: Rewrite the Slack paragraph to say that placeholder-backed channel configuration is forwarded to the sandbox, while raw `SLACK_BOT_TOKEN` and `SLACK_APP_TOKEN` values remain in OpenShell providers and are only injected by the gateway at egress, if that is the intended contract.
    • Evidence: `skills/nemoclaw-user-reference/references/commands.md:161-163` says the app-level token is stored in a provider and forwarded to the sandbox alongside the bot token. `skills/nemoclaw-user-reference/references/architecture.md:121-122` says NemoClaw never gives the sandbox a raw provider key and uses provider placeholders; `architecture.md:250-253` says Telegram and Slack tokens are stored as providers and not passed directly to the sandbox.
  • Coordinate overlapping catalog refresh before landing generated skill content (skills/nemoclaw-user-overview/SKILL.md:1): This PR adds and signs root catalog skill packages while another active catalog refresh overlaps the same published `skills/nemoclaw-user-overview/**` and `skills/nemoclaw-user-reference/**` files. Because the root `skills/` directory is the watched publication surface, independent refreshes can cause generated-content and signature drift.
    • Recommendation: Coordinate with the overlapping catalog refresh so only one source of the root publication content and signatures lands for these two skill packages, or rebase/regenerate after the overlap is resolved.
    • Evidence: Deterministic drift context reported open PR chore(skills): refresh catalog export #4344, `chore(skills): refresh catalog export`, with same-file overlap across the overview and reference root catalog skill files, including `SKILL.md`, references, and the image. `.github/catalog-skills-signing-flow.md` states the root `skills/` directory is the NVSkills watched publication surface.

🌱 Nice ideas

  • None.
Since last review details

Current findings:

  • Source-of-truth review needed: Generated user-skill eval schema simplification: The advisor marked localized patch analysis as needs_followup.
    • Recommendation: Identify the invalid state, source boundary, source-fix constraint, regression test, and removal condition before merging the localized behavior.
    • Evidence: The PR removes `expected_behavior` arrays from four `.agents/skills/nemoclaw-user-*` eval files while sibling user-skill evals still retain that field.
  • Resolve failed benchmarks before publishing the signed skills (skills/nemoclaw-user-overview/BENCHMARK.md:12): Both newly published root catalog skills include signed catalog artifacts, but their committed benchmark reports still say the overall verdict is FAIL and recommend addressing findings before NVSkills-Eval publication. That conflicts with the catalog-publication intent and with the generated skill cards saying the skills are ready for use.
    • Recommendation: Address the benchmark findings or regenerate the benchmark reports after a passing publication evaluation before treating these root `skills/` packages as ready for catalog publication. If FAIL is expected for this signing batch, document that exception in the committed artifact so the publication state is not contradictory.
    • Evidence: `skills/nemoclaw-user-overview/BENCHMARK.md:12` and `skills/nemoclaw-user-reference/BENCHMARK.md:12` say `Overall verdict: FAIL`; `skills/nemoclaw-user-overview/BENCHMARK.md:68` and `skills/nemoclaw-user-reference/BENCHMARK.md:72` say the skill owners should address findings and rerun NVSkills-Eval before publication. The corresponding `skill-card.md` files say the skills are ready for commercial/non-commercial use.
  • Ground-truth-only evals drop structured behavior checks (.agents/skills/nemoclaw-user-overview/evals/evals.json:1): The PR removes every `expected_behavior` array from four source eval files and publishes root evals that only keep `ground_truth`. Sibling NemoClaw user-skill evals still use `expected_behavior` to assert the assistant loads the expected skill/reference, avoids unsupported NemoClaw behavior, and follows progressive disclosure. These checks matter for security-sensitive installation, policy, inference, and operations guidance.
    • Recommendation: Either preserve the `expected_behavior` arrays for these evals, or include the evaluator/schema update and fixture evidence showing that the simplified `ground_truth`-only format still enforces the removed behaviors.
    • Evidence: The diff removes `expected_behavior` from `.agents/skills/nemoclaw-user-agent-skills/evals/evals.json`, `.agents/skills/nemoclaw-user-get-started/evals/evals.json`, `.agents/skills/nemoclaw-user-overview/evals/evals.json`, and `.agents/skills/nemoclaw-user-reference/evals/evals.json`. Repository siblings such as `.agents/skills/nemoclaw-user-deploy-remote/evals/evals.json`, `.agents/skills/nemoclaw-user-manage-policy/evals/evals.json`, and `.agents/skills/nemoclaw-user-configure-security/evals/evals.json` still contain those structured assertions.
  • Remote bind examples need explicit network-exposure controls (skills/nemoclaw-user-reference/references/commands.md:1199): The published skill documents `NEMOCLAW_GATEWAY_BIND_ADDRESS=0.0.0.0` and `NEMOCLAW_DASHBOARD_BIND=0.0.0.0`. The current text notes that services may become reachable and that non-loopback origins are accepted for dashboard auth, but these command snippets are likely to be surfaced directly by AI assistants and should carry a hard warning about trusted networks and access controls.
    • Recommendation: Add a short, hard-to-miss warning near the environment table and the `0.0.0.0` examples stating that remote binding exposes the gateway/dashboard beyond loopback and should only be used behind explicit controls such as firewall rules, VPN, or SSH tunneling, and not on public or untrusted LAN interfaces.
    • Evidence: `skills/nemoclaw-user-reference/references/commands.md:1199` lists `NEMOCLAW_GATEWAY_BIND_ADDRESS` as accepting `0.0.0.0`; `commands.md:1204` documents `NEMOCLAW_DASHBOARD_BIND`; `commands.md:1212-1218` says remote bind may make services reachable and dashboard auth accepts non-loopback origins; `commands.md:1226` and `skills/nemoclaw-user-reference/references/troubleshooting.md:208` show direct `0.0.0.0` examples.
  • Clarify Slack token wording so it does not imply raw secrets enter the sandbox (skills/nemoclaw-user-reference/references/commands.md:163): The command reference says the Slack app-level token is stored in an OpenShell provider and `forwarded to the sandbox alongside the bot token`. That wording conflicts with the architecture reference, which says raw credentials are never passed directly to the sandbox and that the sandbox receives placeholders. For a credential-handling guide, this ambiguity can lead users or agents to accept an unsafe mental model.
    • Recommendation: Rewrite the Slack paragraph to say that placeholder-backed channel configuration is forwarded to the sandbox, while raw `SLACK_BOT_TOKEN` and `SLACK_APP_TOKEN` values remain in OpenShell providers and are only injected by the gateway at egress, if that is the intended contract.
    • Evidence: `skills/nemoclaw-user-reference/references/commands.md:161-163` says the app-level token is stored in a provider and forwarded to the sandbox alongside the bot token. `skills/nemoclaw-user-reference/references/architecture.md:121-122` says NemoClaw never gives the sandbox a raw provider key and uses provider placeholders; `architecture.md:250-253` says Telegram and Slack tokens are stored as providers and not passed directly to the sandbox.
  • Coordinate overlapping catalog refresh before landing generated skill content (skills/nemoclaw-user-overview/SKILL.md:1): This PR adds and signs root catalog skill packages while another active catalog refresh overlaps the same published `skills/nemoclaw-user-overview/**` and `skills/nemoclaw-user-reference/**` files. Because the root `skills/` directory is the watched publication surface, independent refreshes can cause generated-content and signature drift.
    • Recommendation: Coordinate with the overlapping catalog refresh so only one source of the root publication content and signatures lands for these two skill packages, or rebase/regenerate after the overlap is resolved.
    • Evidence: Deterministic drift context reported open PR chore(skills): refresh catalog export #4344, `chore(skills): refresh catalog export`, with same-file overlap across the overview and reference root catalog skill files, including `SKILL.md`, references, and the image. `.github/catalog-skills-signing-flow.md` states the root `skills/` directory is the NVSkills watched publication surface.

Workflow run details

This is an automated advisory review. A human maintainer must make the final merge decision.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 8

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.agents/skills/nemoclaw-user-agent-skills/evals/evals.json:
- Line 6: The ground_truth string mixes pronouns/perspectives ("the user" and
"my AI coding assistant"); update the value of the ground_truth key in
evals.json to use a single consistent POV (e.g., change "my AI coding assistant"
to "their AI coding assistant") so the evaluation criterion is unambiguous;
locate the ground_truth property in
.agents/skills/nemoclaw-user-agent-skills/evals/evals.json and normalize the
phrasing accordingly.

In @.agents/skills/nemoclaw-user-get-started/evals/evals.json:
- Line 6: Update the eval rubric strings in
.agents/skills/nemoclaw-user-get-started/evals/evals.json to use neutral
third-person phrasing: replace first-person possessives like "my" with "their"
(e.g., in the "ground_truth" value and the other rubric strings referenced at
the same entries). Search for the JSON keys/strings that mention "my host" or
similar (including the "ground_truth" field and the other rubric entries
flagged) and edit them so each criterion consistently uses "the user" or "their"
instead of first-person wording.

In @.agents/skills/nemoclaw-user-overview/evals/evals.json:
- Line 6: Update the JSON "ground_truth" field to use a single, consistent
third-person perspective (prefer "their") instead of mixing first-person
("me/I/my") and third-person ("the user"); locate the "ground_truth" entries
(the string values flagged on lines 6, 18, 42, 48, 78, 90 in the evals.json
diff) and rewrite each sentence to replace "me/I/my" or "the user" with "their"
(or rephrase as needed) so the rubric language is unambiguous and consistent
across all occurrences.

In @.agents/skills/nemoclaw-user-reference/evals/evals.json:
- Line 24: The rubric strings in the JSON "ground_truth" fields mix third-person
and first-person pronouns; update any "ground_truth" entries that use "my" or
"I" to use consistent third-person phrasing (e.g., change "my operation" to "the
operation", "helps the user ... that owns my operation" to "helps the user ...
that owns the operation", and "I" to "the assistant" or rephrase into
third-person as appropriate). Locate these strings by searching for the
"ground_truth" key in the evals.json and apply the pronoun substitutions
consistently across all occurrences that contain first-person wording.

In `@skills/nemoclaw-user-overview/references/ecosystem.md`:
- Around line 16-18: Update the Mermaid node labels to remove emoji by editing
the three node definitions NC, OS, and OC (currently labeled NC["🦞 NVIDIA
NemoClaw<br/>CLI, plugin, blueprint"], OS["🐚 NVIDIA OpenShell<br/>Gateway,
policy, inference routing"], OC["🦞 OpenClaw<br/>Assistant in sandbox"]) and
replace them with plain-text labels such as NC["NVIDIA NemoClaw<br/>CLI, plugin,
blueprint"], OS["NVIDIA OpenShell<br/>Gateway, policy, inference routing"], and
OC["OpenClaw<br/>Assistant in sandbox"] so the diagram uses no emoji in
technical prose.

In `@skills/nemoclaw-user-overview/references/overview.md`:
- Line 8: Update the sentence in the overview content that reads "This enables
self-evolving claws to run more safely in clouds, on prem, RTX PCs and DGX
Spark." by replacing the phrase "on prem" with the hyphenated form "on-prem" to
match technical-doc consistency; edit the text in the markdown content
(overview.md) so it becomes "clouds, on-prem, RTX PCs and DGX Spark."

In `@skills/nemoclaw-user-overview/SKILL.md`:
- Line 3: Update the trigger keywords in the SKILL.md description to use the
required NVIDIA capitalization: replace the tokens "nvidia openshell" and
"nvidia nemotron" with "NVIDIA OpenShell" and "NVIDIA Nemotron" respectively
(these appear inside the description/trigger keywords string); ensure the rest
of the comma-separated keywords remain unchanged and that "NVIDIA" is all-caps
per project Markdown naming rules.

In `@skills/nemoclaw-user-reference/references/architecture.md`:
- Line 20: Remove emoji from the mermaid node labels so they comply with the "No
emoji in technical prose" rule: replace labels like USER(["👤 User"]):::user and
any other nodes containing emojis (e.g., the node with "🔒") with plain text
labels such as USER(["User"]):::user and the corresponding locking/security node
without emoji; update all occurrences noted (lines referenced in the review: the
nodes at the shown diff and the other instances) to use plain text only while
keeping the same node identifiers and classes.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 8562b269-fb15-485d-8379-882bdadb8379

📥 Commits

Reviewing files that changed from the base of the PR and between 195bbcc and c077a35.

⛔ Files ignored due to path filters (1)
  • skills/nemoclaw-user-overview/references/images/nemoclaw-highlevel-component-diagram.png is excluded by !**/*.png
📒 Files selected for processing (17)
  • .agents/skills/nemoclaw-user-agent-skills/evals/evals.json
  • .agents/skills/nemoclaw-user-get-started/evals/evals.json
  • .agents/skills/nemoclaw-user-overview/evals/evals.json
  • .agents/skills/nemoclaw-user-reference/evals/evals.json
  • skills/nemoclaw-user-overview/SKILL.md
  • skills/nemoclaw-user-overview/evals/evals.json
  • skills/nemoclaw-user-overview/references/ecosystem.md
  • skills/nemoclaw-user-overview/references/how-it-works.md
  • skills/nemoclaw-user-overview/references/overview.md
  • skills/nemoclaw-user-overview/references/release-notes.md
  • skills/nemoclaw-user-reference/SKILL.md
  • skills/nemoclaw-user-reference/evals/evals.json
  • skills/nemoclaw-user-reference/references/architecture.md
  • skills/nemoclaw-user-reference/references/cli-selection-guide.md
  • skills/nemoclaw-user-reference/references/commands.md
  • skills/nemoclaw-user-reference/references/network-policies.md
  • skills/nemoclaw-user-reference/references/troubleshooting.md

"The output avoids inventing unsupported NemoClaw behavior.",
"The output follows progressive disclosure: it answers the current request without dumping unrelated details other than the expected_skill and the references/agent-skills.md file."
]
"ground_truth": "A NemoClaw-specific answer that helps the user find a skill that can guide installation, policy, inference, or operations and gives enough concrete guidance, decision criteria, verification steps, or risk framing to delegate the right workflow to my AI coding assistant."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Normalize mixed pronouns in ground_truth.

Line 6 mixes perspectives (the user + my AI coding assistant). Use a single POV (e.g., their AI coding assistant) to keep eval criteria unambiguous.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.agents/skills/nemoclaw-user-agent-skills/evals/evals.json at line 6, The
ground_truth string mixes pronouns/perspectives ("the user" and "my AI coding
assistant"); update the value of the ground_truth key in evals.json to use a
single consistent POV (e.g., change "my AI coding assistant" to "their AI coding
assistant") so the evaluation criterion is unambiguous; locate the ground_truth
property in .agents/skills/nemoclaw-user-agent-skills/evals/evals.json and
normalize the phrasing accordingly.

"The output avoids inventing unsupported NemoClaw behavior.",
"The output follows progressive disclosure: it answers the current request without dumping unrelated details other than the expected_skill and the references/prerequisites.md file."
]
"ground_truth": "A NemoClaw-specific answer that helps the user verify my host has the required hardware, software, and platform support and gives enough concrete guidance, decision criteria, verification steps, or risk framing to avoid a failed first setup."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Use consistent third-person phrasing in eval rubric strings.

Lines 6, 42, and 60 mix the user with first-person terms (my). Please normalize to neutral third-person wording (their) for consistent scoring criteria.

Also applies to: 42-42, 60-60

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.agents/skills/nemoclaw-user-get-started/evals/evals.json at line 6, Update
the eval rubric strings in
.agents/skills/nemoclaw-user-get-started/evals/evals.json to use neutral
third-person phrasing: replace first-person possessives like "my" with "their"
(e.g., in the "ground_truth" value and the other rubric strings referenced at
the same entries). Search for the JSON keys/strings that mention "my host" or
similar (including the "ground_truth" field and the other rubric entries
flagged) and edit them so each criterion consistently uses "the user" or "their"
instead of first-person wording.

"The output avoids inventing unsupported NemoClaw behavior.",
"The output follows progressive disclosure: it answers the current request without dumping unrelated details other than the expected_skill and the SKILL.md file."
]
"ground_truth": "A NemoClaw-specific answer that helps the user understand what NemoClaw helps me run and why it exists and gives enough concrete guidance, decision criteria, verification steps, or risk framing to decide whether it is worth installing before I spend time on setup."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Fix mixed first-person/third-person perspective in ground_truth.

Lines 6, 18, 42, 48, 78, and 90 combine the user with me/I/my. Keep a single perspective (prefer their) to avoid ambiguous rubric language.

Also applies to: 18-18, 42-42, 48-48, 78-78, 90-90

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.agents/skills/nemoclaw-user-overview/evals/evals.json at line 6, Update the
JSON "ground_truth" field to use a single, consistent third-person perspective
(prefer "their") instead of mixing first-person ("me/I/my") and third-person
("the user"); locate the "ground_truth" entries (the string values flagged on
lines 6, 18, 42, 48, 78, 90 in the evals.json diff) and rewrite each sentence to
replace "me/I/my" or "the user" with "their" (or rephrase as needed) so the
rubric language is unambiguous and consistent across all occurrences.

"The output avoids inventing unsupported NemoClaw behavior.",
"The output follows progressive disclosure: it answers the current request without dumping unrelated details other than the expected_skill and the references/cli-selection-guide.md file."
]
"ground_truth": "A NemoClaw-specific answer that helps the user pick the command surface that owns my operation and gives enough concrete guidance, decision criteria, verification steps, or risk framing to complete the task without breaking NemoClaw management."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Standardize pronouns in rubric text.

Lines 24, 42, and 78 mix the user with first-person wording (my/I). Please switch to consistent third-person phrasing for cleaner evaluation criteria.

Also applies to: 42-42, 78-78

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.agents/skills/nemoclaw-user-reference/evals/evals.json at line 24, The
rubric strings in the JSON "ground_truth" fields mix third-person and
first-person pronouns; update any "ground_truth" entries that use "my" or "I" to
use consistent third-person phrasing (e.g., change "my operation" to "the
operation", "helps the user ... that owns my operation" to "helps the user ...
that owns the operation", and "I" to "the assistant" or rephrase into
third-person as appropriate). Locate these strings by searching for the
"ground_truth" key in the evals.json and apply the pronoun substitutions
consistently across all occurrences that contain first-person wording.

Comment on lines +16 to +18
NC["🦞 NVIDIA NemoClaw<br/>CLI, plugin, blueprint"]
OS["🐚 NVIDIA OpenShell<br/>Gateway, policy, inference routing"]
OC["🦞 OpenClaw<br/>Assistant in sandbox"]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove emoji from technical diagram labels.

Please replace the lobster/shell emoji in Mermaid node labels with plain text labels to satisfy the Markdown prose style rule.

As per coding guidelines, "No emoji in technical prose."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-overview/references/ecosystem.md` around lines 16 - 18,
Update the Mermaid node labels to remove emoji by editing the three node
definitions NC, OS, and OC (currently labeled NC["🦞 NVIDIA NemoClaw<br/>CLI,
plugin, blueprint"], OS["🐚 NVIDIA OpenShell<br/>Gateway, policy, inference
routing"], OC["🦞 OpenClaw<br/>Assistant in sandbox"]) and replace them with
plain-text labels such as NC["NVIDIA NemoClaw<br/>CLI, plugin, blueprint"],
OS["NVIDIA OpenShell<br/>Gateway, policy, inference routing"], and
OC["OpenClaw<br/>Assistant in sandbox"] so the diagram uses no emoji in
technical prose.

NVIDIA NemoClaw is an open-source reference stack that simplifies running [OpenClaw](https://openclaw.ai) always-on assistants more safely.
NemoClaw provides onboarding, lifecycle management, and OpenClaw operations within OpenShell containers.
It incorporates policy-based privacy and security guardrails, giving you control over your agents’ behavior and data handling.
This enables self-evolving claws to run more safely in clouds, on prem, RTX PCs and DGX Spark.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Hyphenate “on-prem” for technical-doc consistency.

Use on-prem instead of on prem in this sentence.

🧰 Tools
🪛 LanguageTool

[grammar] ~8-~8: Use a hyphen to join words.
Context: ...g claws to run more safely in clouds, on prem, RTX PCs and DGX Spark. NemoClaw p...

(QB_NEW_EN_HYPHEN)

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-overview/references/overview.md` at line 8, Update the
sentence in the overview content that reads "This enables self-evolving claws to
run more safely in clouds, on prem, RTX PCs and DGX Spark." by replacing the
phrase "on prem" with the hyphenated form "on-prem" to match technical-doc
consistency; edit the text in the markdown content (overview.md) so it becomes
"clouds, on-prem, RTX PCs and DGX Spark."

@@ -0,0 +1,17 @@
---
name: "nemoclaw-user-overview"
description: "Explains how OpenClaw, OpenShell, and NemoClaw form the ecosystem, NemoClaw's position in the stack, what NemoClaw adds beyond the community sandbox, and when to prefer NemoClaw versus integrating OpenShell and OpenClaw directly. Use when users ask about the relationship between OpenClaw, OpenShell, and NemoClaw, or when to use NemoClaw versus OpenShell. Trigger keywords - nemoclaw ecosystem, openclaw openshell, nemoclaw vs openshell, sandboxed openclaw, how nemoclaw works, nemoclaw sandbox lifecycle blueprint, nemoclaw overview, openclaw always-on assistants, nvidia openshell, nvidia nemotron, nemoclaw release notes, nemoclaw changelog."
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Normalize NVIDIA capitalization in trigger keywords.

nvidia openshell and nvidia nemotron should be NVIDIA OpenShell and NVIDIA Nemotron to comply with project-wide Markdown naming rules.

As per coding guidelines, "NVIDIA must be all caps (not Nvidia, nvidia)."

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-overview/SKILL.md` at line 3, Update the trigger
keywords in the SKILL.md description to use the required NVIDIA capitalization:
replace the tokens "nvidia openshell" and "nvidia nemotron" with "NVIDIA
OpenShell" and "NVIDIA Nemotron" respectively (these appear inside the
description/trigger keywords string); ensure the rest of the comma-separated
keywords remain unchanged and that "NVIDIA" is all-caps per project Markdown
naming rules.

classDef external fill:#f5f5f5,stroke:#e0e0e0,color:#1a1a1a,stroke-width:1px
classDef user fill:#fff,stroke:#76b900,color:#1a1a1a,stroke-width:2px,font-weight:bold

USER(["👤 User"]):::user
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove emoji from diagram labels to satisfy docs policy.

The mermaid node labels include emoji (👤, 🔒), which violates the Markdown docs rule for technical prose.

Suggested diff
-    USER(["👤 User"]):::user
+    USER(["User"]):::user
...
-            subgraph SANDBOX["Sandbox Container 🔒"]
+            subgraph SANDBOX["Sandbox Container"]
...
-            SANDBOX["Sandbox container 🔒<br/><small>Landlock + seccomp + netns<br/>OpenClaw agent + NemoClaw plugin</small>"]:::sandbox
+            SANDBOX["Sandbox container<br/><small>Landlock + seccomp + netns<br/>OpenClaw agent + NemoClaw plugin</small>"]:::sandbox

As per coding guidelines, "No emoji in technical prose."

Also applies to: 43-43, 94-94

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-reference/references/architecture.md` at line 20, Remove
emoji from the mermaid node labels so they comply with the "No emoji in
technical prose" rule: replace labels like USER(["👤 User"]):::user and any
other nodes containing emojis (e.g., the node with "🔒") with plain text labels
such as USER(["User"]):::user and the corresponding locking/security node
without emoji; update all occurrences noted (lines referenced in the review: the
nodes at the shown diff and the other instances) to use plain text only while
keeping the same node identifiers and classes.

Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot Bot commented May 28, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@skills/nemoclaw-user-reference/skill-card.md`:
- Line 1: The file is missing the required SPDX header in HTML comment format;
add an SPDX license header (e.g. <!-- SPDX-License-Identifier: MIT --> with the
correct license identifier) at the very top of the Markdown file above the
existing content (above the "## Description" header) so the file complies with
the rule for "*.md" files to include SPDX headers.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: eae9738d-38ab-4d67-b34a-b288744f59c1

📥 Commits

Reviewing files that changed from the base of the PR and between c077a35 and af2ba88.

📒 Files selected for processing (6)
  • skills/nemoclaw-user-overview/BENCHMARK.md
  • skills/nemoclaw-user-overview/skill-card.md
  • skills/nemoclaw-user-overview/skill.oms.sig
  • skills/nemoclaw-user-reference/BENCHMARK.md
  • skills/nemoclaw-user-reference/skill-card.md
  • skills/nemoclaw-user-reference/skill.oms.sig
✅ Files skipped from review due to trivial changes (5)
  • skills/nemoclaw-user-reference/skill.oms.sig
  • skills/nemoclaw-user-reference/BENCHMARK.md
  • skills/nemoclaw-user-overview/skill.oms.sig
  • skills/nemoclaw-user-overview/BENCHMARK.md
  • skills/nemoclaw-user-overview/skill-card.md

@@ -0,0 +1,55 @@
## Description: <br>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add required SPDX header at file top.

This Markdown file is missing the required SPDX header in HTML comment format.

Proposed fix
+<!-- SPDX-License-Identifier: Apache-2.0 -->
+
 ## Description: <br>
 Describes the NemoClaw plugin and blueprint architecture and how they orchestrate the OpenClaw sandbox. <br>

As per coding guidelines, "**/*.md: Markdown documentation files must include SPDX headers in HTML comment format".

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
## Description: <br>
<!-- SPDX-License-Identifier: Apache-2.0 -->
## Description: <br>
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@skills/nemoclaw-user-reference/skill-card.md` at line 1, The file is missing
the required SPDX header in HTML comment format; add an SPDX license header
(e.g. <!-- SPDX-License-Identifier: MIT --> with the correct license identifier)
at the very top of the Markdown file above the existing content (above the "##
Description" header) so the file complies with the rule for "*.md" files to
include SPDX headers.

@miyoungc miyoungc merged commit e97346b into main May 28, 2026
21 checks passed
@miyoungc miyoungc deleted the skills-sign-batch-5 branch May 28, 2026 21:32
@coderabbitai coderabbitai Bot mentioned this pull request May 28, 2026
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants