chore: skills signing batch 2#4463
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughThis PR adds comprehensive docs, evaluation datasets, and artifacts for two NemoClaw skills (inference configuration and security best practices) and removes ChangesNemoClaw Inference Configuration Skill
NemoClaw Security Best Practices Skill
Agent-Side Evaluation Schema Simplification
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRsSuggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/nvskills-ci |
E2E Advisor RecommendationRequired E2E: None Dispatch hint: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
E2E Scenario Advisor RecommendationRequired scenario E2E: None Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
PR Review AdvisorFindings: 0 needs attention, 9 worth checking, 1 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
skills/nemoclaw-user-configure-inference/evals/evals.json (1)
1-92: ⚡ Quick winAvoid maintaining a second handwritten copy of this eval dataset.
This file matches
.agents/skills/nemoclaw-user-configure-inference/evals/evals.jsonentry-for-entry. Keeping both copies editable will drift sooner or later; please generate one from the other or add a sync check in CI.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@skills/nemoclaw-user-configure-inference/evals/evals.json` around lines 1 - 92, This eval dataset is duplicated elsewhere in the repo; remove manual duplication by making this evals.json the single source of truth and either (a) regenerate the other copy from this file during the build or (b) add a CI sync check that diffs this evals.json against the duplicate and fails if they diverge; implement the generator or CI check as a script (e.g., sync-evals.sh or a Node/Python script invoked by CI) and update the PR to remove the redundant handwritten copy so only one evals.json is edited going forward.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@skills/nemoclaw-user-configure-inference/evals/evals.json`:
- Around line 1-92: This eval dataset is duplicated elsewhere in the repo;
remove manual duplication by making this evals.json the single source of truth
and either (a) regenerate the other copy from this file during the build or (b)
add a CI sync check that diffs this evals.json against the duplicate and fails
if they diverge; implement the generator or CI check as a script (e.g.,
sync-evals.sh or a Node/Python script invoked by CI) and update the PR to remove
the redundant handwritten copy so only one evals.json is edited going forward.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: de9f5829-9997-4b7a-bced-97dd7fd927c2
📒 Files selected for processing (14)
.agents/skills/nemoclaw-user-configure-inference/evals/evals.json.agents/skills/nemoclaw-user-configure-security/evals/evals.jsonskills/nemoclaw-user-configure-inference/SKILL.mdskills/nemoclaw-user-configure-inference/evals/evals.jsonskills/nemoclaw-user-configure-inference/references/inference-options.mdskills/nemoclaw-user-configure-inference/references/set-up-sub-agent.mdskills/nemoclaw-user-configure-inference/references/switch-inference-providers.mdskills/nemoclaw-user-configure-inference/references/tool-calling-reliability.mdskills/nemoclaw-user-configure-inference/references/use-local-inference-details.mdskills/nemoclaw-user-configure-security/SKILL.mdskills/nemoclaw-user-configure-security/evals/evals.jsonskills/nemoclaw-user-configure-security/references/best-practices.mdskills/nemoclaw-user-configure-security/references/credential-storage.mdskills/nemoclaw-user-configure-security/references/openclaw-controls.md
Signed-off-by: nvskills-svc-account <svc-nvskills-signing@nvidia.com>
|
Actionable comments posted: 0 |
Summary
Related Issue
Changes
Type of Change
Verification
npx prek run --all-filespassesnpm testpassesnpm run docsbuilds without warnings (doc changes only)Signed-off-by: Your Name your-email@example.com
Summary by CodeRabbit
Documentation
Tests