fix(messaging): activate OpenClaw channels in generated config#4400
Closed
ericksoa wants to merge 14 commits into
Closed
fix(messaging): activate OpenClaw channels in generated config#4400ericksoa wants to merge 14 commits into
ericksoa wants to merge 14 commits into
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughThe PR standardizes OpenClaw channel configuration generation to unconditionally enable all messaging channels (discord, slack, telegram, whatsapp) with consistent ChangesOpenClaw Channel Configuration and Validation
Sequence Diagram(s)sequenceDiagram
participant Phase3Test as Phase 3 Test
participant assert_config as assert_openclaw_config_activation()
participant ConfigJSON as openclaw.json
participant assert_runtime as assert_openclaw_runtime_channel()
participant OpenClawCLI as openclaw channels list
Phase3Test->>assert_config: For each: telegram/discord/slack/whatsapp
assert_config->>ConfigJSON: Parse channels[ch].enabled
assert_config->>ConfigJSON: Parse plugins.entries[ch].enabled
assert_config-->>Phase3Test: Config activation verified
Phase3Test->>assert_runtime: For each channel with expected_account
assert_runtime->>OpenClawCLI: channels list --all --json
OpenClawCLI-->>assert_runtime: Channel report with accounts list
assert_runtime->>assert_runtime: Validate installed=true, origin=configured
assert_runtime-->>Phase3Test: Runtime status verified
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ericksoa
added
bug
Contributor
E2E Advisor RecommendationRequired E2E: Dispatch hint: Auto-dispatched E2E: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
Contributor
E2E Scenario Advisor RecommendationRequired scenario E2E: None Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
Contributor
PR Review AdvisorFindings: 1 needs attention, 5 worth checking, 1 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
Since last review detailsCurrent findings:
This is an automated advisory review. A human maintainer must make the final merge decision. |
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26554878579
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26554971569
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26555201622
|
…g-channel-activation
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26555633394
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26555917728
|
Contributor
Selective E2E Results — ❌ Some jobs failedRun: 26555952807
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26556278457
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26556305176
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26556339630
|
Contributor
Selective E2E Results — ❌ Some jobs failedRun: 26556385921
|
Contributor
Selective E2E Results — ❌ Some jobs failedRun: 26556728169
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26558414515
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26558462965
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26558533594
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26574867357
|
Contributor
Selective E2E Results — ❌ Some jobs failedRun: 26575112381
|
Contributor
Selective E2E Results — ❌ Some jobs failedRun: 26576407782
|
…g-channel-activation
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26577380287
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26577504339
|
Contributor
Selective E2E Results — ✅ All requested jobs passedRun: 26577645435
|
7 tasks
ericksoa
added a commit
that referenced
this pull request
May 28, 2026
…ter rebuild (#4403) ## Summary Fixes #4314 Fixes #4390 This is now the unified messaging-channel PR: it keeps the original #4403 runtime verification path and folds in the full #4400 OpenClaw channel activation / plugin-build / E2E coverage set. OpenClaw 2026.5.22+ no longer auto-starts a messaging bridge from the account-level `enabled` flag alone — the channel must also be marked enabled at the top level for the bridge module to load. NemoClaw#4189 fixed this for Slack (PR #4222); the same gap silently produced "no Telegram process / no logs" for Telegram (#4314, #4390) and would silently break Discord too. This PR: - Bakes `channels.<name>.enabled: true` for Telegram, Discord, Slack, and WhatsApp in generated `openclaw.json`. - Enables matching `plugins.entries.<channel>` records so OpenClaw discovers selected messaging providers through its real channel/plugin path. - Pins external OpenClaw messaging plugins at image build time with `scripts/openclaw-build-messaging-plugins.py` instead of relying on unversioned `openclaw doctor --fix` catalog drift. - Adds a gated Telegram startup-grace diagnostic breadcrumb when the bridge fails to log startup within the grace window. - Adds a post-rebuild runtime check to `nemoclaw <sandbox> channels add <channel>` for verifiable OpenClaw channels (telegram/discord/slack), surfacing missing enabled flags, missing startup breadcrumbs, and credential/startup warnings. - Extends messaging-provider E2E coverage with generated activation checks, `openclaw channels list --all --json` runtime discovery checks, pinned plugin build coverage, fake provider APIs, and optional live Telegram/Discord/Slack `openclaw message send` paths when repository secrets are configured. - Keeps WeChat out of upfront generated channel config; WeChat remains on the existing late seed path after plugin install. ## Reproduction (issue #4390 + #4314) Before the fix, generated config with Telegram selected during onboarding: ```json "channels": { "telegram": { "accounts": { "default": { ... } } } } ``` No top-level `enabled: true` meant OpenClaw skipped loading the bridge. No Telegram process spawned, `/sandbox/.openclaw/telegram/` stayed empty, and no startup/error breadcrumb appeared. After the fix: ```json "channels": { "telegram": { "enabled": true, "accounts": { "default": { ..., "enabled": true } } } } ``` The bridge module is loadable, diagnostics can report silent startup failure, and `channels add telegram` probes the rebuilt runtime instead of leaving users with radio silence. ## Test plan Local validation on the unified branch: - [x] `python3 -m py_compile scripts/generate-openclaw-config.py scripts/openclaw-build-messaging-plugins.py` - [x] `NEMOCLAW_MESSAGING_CHANNELS_B64=$(printf '%s' '["telegram","discord","slack","whatsapp"]' | base64 | tr -d '\n') OPENCLAW_VERSION=2026.5.22 python3 scripts/openclaw-build-messaging-plugins.py --dry-run` - [x] `bash -n test/e2e/test-messaging-providers.sh test/e2e/lib/discord-rest-policy-proof.sh test/e2e/lib/slack-api-proof.sh test/e2e/lib/telegram-api-proof.sh` - [x] `git diff --check HEAD~1..HEAD` - [x] `npm ci --ignore-scripts` - [x] `npm run build:cli` - [x] `npx vitest run test/generate-openclaw-config.test.ts test/openclaw-build-messaging-plugins.test.ts test/sandbox-build-context.test.ts test/sandbox-provisioning.test.ts test/channels-add-preset.test.ts test/telegram-diagnostics.test.ts test/e2e-script-workflow.test.ts test/validate-e2e-coverage.test.ts` — 160 passed Live Telegram bot E2E was not run from the local triage worktree because no Telegram bot credential is available locally; the PR wires optional live repository secrets through the nightly reusable workflow and keeps hermetic fake-provider proofs for CI. ## DCO ``` Signed-off-by: Yimo Jiang <yimoj@nvidia.com> ``` <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Startup watchdog emits a single breadcrumb when an OpenClaw gateway bridge fails to start within a configurable grace period. * Post-channel-add now verifies bridged channels after a rebuild. * Image/sandbox build now includes a messaging-plugin installer to pin/install provider plugins. * **Bug Fixes** * Ensure channels, accounts, and plugin entries are marked enabled so bridges activate reliably. * **Tests** * Expanded regression/E2E coverage with fake provider APIs, startup diagnostics, and live-credential wiring for Telegram/Discord/Slack. <!-- review_stack_entry_start --> [](https://app.coderabbit.ai/change-stack/NVIDIA/NemoClaw/pull/4403?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack) <!-- review_stack_entry_end --> <!-- end of auto-generated comment: release notes by coderabbit.ai --> --------- Signed-off-by: Yimo Jiang <yimoj@nvidia.com> Co-authored-by: Aaron Erickson <aerickson@nvidia.com>
Contributor
](https://app.coderabbit.ai/change-stack/NVIDIA/NemoClaw/pull/4403?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack){kind=link}
wscurran
added
area: e2e
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openclaw.jsonfor Telegram, Discord, Slack, and WhatsApp.plugins.entries.<channel>records so OpenClaw discovers selected messaging providers through its real channel/plugin path.test/e2e/test-messaging-providers.shto verify both generated activation andopenclaw channels list --all --jsonruntime discovery for Telegram, Discord, Slack, and WhatsApp.Refs #4251
Test Plan
python3 -m py_compile scripts/generate-openclaw-config.pygit diff --checkbash -n test/e2e/test-messaging-providers.shnpm test -- test/generate-openclaw-config.test.tsnpm test -- test/nemoclaw-start.test.tsnpm test -- test/seed-wechat-accounts.test.tsnpm test -- test/onboard-messaging.test.ts -t "non-interactive setupMessagingChannels returns channels with tokens|setupSelectedMessagingChannels|wechat|whatsapp"npm test -- test/validate-e2e-coverage.test.ts test/e2e-scenario/framework-tests/e2e-coverage-report.test.tsnpm run build:cliSummary by CodeRabbit
Tests
Chores