Skip to content

refactor(e2e-advisor): align e2e scenario advisor to better follow e2e advisor flow #4381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jyaunches wants to merge 4 commits into
base: main
Choose a base branch
from
+684 −505
Open

refactor(e2e-advisor): align e2e scenario advisor to better follow e2e advisor flow #4381

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b29a53a
refactor(e2e-advisor): make scenario advisor LLM-driven
jyaunches May 28, 2026
d8139aa
chore(e2e-advisor): mark scenarios.mts executable
jyaunches May 28, 2026
1e479b3
fix(e2e-advisor): allowlist workflow/id and canonicalize dispatch com…
jyaunches May 28, 2026
606494d
fix(e2e-advisor): enforce workflow/id pairing and array-position requ…
jyaunches May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion .github/workflows/e2e-advisor.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,17 +173,24 @@ jobs:
--schema "$ADVISOR_DIR/tools/e2e-advisor/schema.json" \
--out-dir "$GITHUB_WORKSPACE/artifacts/e2e-advisor"

- name: Run deterministic scenario E2E advisor
- name: Run scenario E2E advisor
id: scenario-analysis
continue-on-error: true
env:
BASE_REF: ${{ github.event_name == 'pull_request' && format('origin/{0}', github.base_ref) || (github.event_name == 'workflow_dispatch' && inputs.target_repo != '' && inputs.target_pr != '' && format('target/{0}', inputs.target_base) || inputs.base_ref) }}
HEAD_REF: ${{ github.event_name == 'pull_request' && 'HEAD' || (github.event_name == 'workflow_dispatch' && inputs.target_repo != '' && inputs.target_pr != '' && 'HEAD' || inputs.head_ref) }}
E2E_SCENARIO_ADVISOR_RUN_ANALYSIS: ${{ github.event_name == 'workflow_dispatch' && inputs.run_analysis == false && '0' || '1' }}
# Reuse the shared E2E advisor secret. The scenario advisor is a
# separate prompt/agent but uses the same model and credential.
E2E_ADVISOR_API_KEY: ${{ secrets.PI_E2E_ADVISOR_API_KEY }}
# Optional local-provider-compatible fallback for future upstream/external-advisor use.
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
run: |
cd "$ADVISOR_WORKDIR"
node --experimental-strip-types "$ADVISOR_DIR/tools/e2e-advisor/scenarios.mts" \
--base "$BASE_REF" \
--head "$HEAD_REF" \
--schema "$ADVISOR_DIR/tools/e2e-advisor/scenarios-schema.json" \
--out-dir "$GITHUB_WORKSPACE/artifacts/e2e-advisor"

- name: Publish job summary
Expand Down
Loading
Loading