docs: add DGX local inference walkthrough (Fixes #3231)#4337
Conversation
|
Caution Review failedFailed to post review comments 📝 WalkthroughWalkthroughAdds a new end-to-end DGX Spark/DGX Station local inference guide, integrates it into site navigation and related skill docs, expands several CLI/troubleshooting/security docs, and adds a Vitest check validating code-block formatting in the new guide. ChangesDGX Spark and DGX Station Local Inference Documentation
Estimated code review effort: Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/nemoclaw-user-reference/references/troubleshooting.md:
- Around line 1138-1139: This change edits an autogenerated skill reference and
must be reverted; do not modify generated markdown directly. Revert the manual
edit in the autogenerated file and instead update the canonical docs/source that
generate the skill (the source used to produce the
nemoclaw-user-configure-inference skill reference), then re-run the
documentation/skill generation pipeline so the corrected text is emitted into
the generated nemoclaw-user-*/*.md outputs; ensure CI/linting for autogenerated
skills passes before merging.
In `@docs/inference/dgx-spark-station-local-inference.mdx`:
- Around line 1-12: The frontmatter in the new page is missing required fields
and the SPDX header is incorrectly placed inside the frontmatter; update the
frontmatter to include title, description, keywords, topics, tags, content.type,
difficulty, audience, and status (use the existing title/description/keywords
and add appropriate topics/tags/difficulty/audience/status values), move the
SPDX lines so they appear immediately after the frontmatter block (not inside
it), and ensure the document body contains an H1 that exactly matches the
frontmatter title (i.e., add or replace the top-level heading to match "Set Up
DGX Spark or DGX Station Local Inference").
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1a4e20af-4761-45f1-b0b4-5fdee947e6d3
📒 Files selected for processing (10)
.agents/skills/nemoclaw-user-configure-inference/SKILL.md.agents/skills/nemoclaw-user-configure-inference/references/dgx-spark-station-local-inference.md.agents/skills/nemoclaw-user-get-started/references/prerequisites.md.agents/skills/nemoclaw-user-reference/references/troubleshooting.mddocs/get-started/prerequisites.mdxdocs/index.ymldocs/inference/dgx-spark-station-local-inference.mdxdocs/inference/use-local-inference.mdxdocs/reference/troubleshooting.mdxtest/dgx-local-inference-doc-copy.test.ts
prekshivyas
left a comment
There was a problem hiding this comment.
@deepujain Thanks for putting this together — it's a genuinely useful walkthrough and most of it checks out. A couple of housekeeping items first, then the content fixes.
Before review can pass
- Merge conflicts: the PR is currently
CONFLICTING/DIRTY. Please rebase ontomainand resolve. dco-checkis failing: the commit has aSigned-off-byline, but the workflow also requires one in the PR description. Please addSigned-off-by: Deepak Jain <deepujain@gmail.com>to the PR body. (commit-lintis green — an earlier red entry was a superseded run.)
Required changes before merge
1. Non-interactive examples will exit immediately for a first-time user.
Both --non-interactive examples omit the third-party consent flag, so a new user (no prior acceptance) hits:
ensureUsageNoticeConsentreturnsfalse(src/lib/onboard/usage-notice.ts:153) →onboard.ts:6500process.exit(1).- Plain
--yesdoes not satisfy this — only--yes-i-accept-third-party-software/NEMOCLAW_ACCEPT_THIRD_PARTY_SOFTWARE=1does (legacy-command.ts:240-241vs:246). - The model/image download separately requires
--yes(onboard.ts:3907-3915).
So both examples need both flags, e.g.:
NEMOCLAW_PROVIDER=install-vllm nemoclaw onboard --non-interactive --yes --yes-i-accept-third-party-software2. The "express setup" paragraph describes behavior that isn't in the code.
Lines 66–67 say the installer offers an "express setup" after the third-party notice that selects the local-inference path and policy defaults on DGX Spark/Station. I couldn't find any such flow — express in src/ only refers to the vLLM/Ollama install model-picker path, not a notice-driven onboarding mode. Please remove or rewrite this so it matches the actual wizard.
Non-blocking
- Provider label: the doc shows
**Local vLLM [experimental]**, butproviders.ts:130-131returns exactly"Local vLLM"(no suffix). Suggest dropping[experimental]. - Test rigidity:
test/dgx-local-inference-doc-copy.test.tsasserts every fenced block is bash (toEqual(new Set(["bash"]))). Fine today, but any future non-bash block (e.g. an output sample) will break it.
Verified correct
- vLLM model slug + default (
qwen3.6-27b,vllm-models.ts:41-43,vllm.ts:464), all env vars,install-vllmprovider key, every cross-link/anchor, and the regenerated skill reference for the new page are all accurate.
Once the two required items and the conflicts/DCO are sorted, this is a clear approve.
Fixes NVIDIA#3231 Signed-off-by: Deepak Jain <deepujain@gmail.com>
c2a2ebf to
f44331f
Compare
|
Rebased on current main, cleaned up the DGX walkthrough review items, regenerated the user skills, and added the PR-body sign-off. Focused docs copy test passes. |
Summary
Adds a single DGX Spark and DGX Station local-inference walkthrough so users do not have to stitch together host prep, provider selection, vLLM/Ollama setup, verification, and Spark-specific troubleshooting from several pages.
Fixes #3231.
Changes
docs/inference/dgx-spark-station-local-inference.mdxwith GPU/CDI checks, provider choice guidance, managed vLLM commands, verification steps, and common DGX fixes.Testing
python3 scripts/docs-to-skills.py docs/ .agents/skills/ --prefix nemoclaw-user --doc-platform fern-mdxnpm run build:clinpm run typecheck:clinpm run docsnpx vitest run test/dgx-local-inference-doc-copy.test.tsEvidence it works
nemoclaw-user-configure-inferenceskill now points DGX Spark and DGX Station questions to the new walkthrough.Summary by CodeRabbit
Documentation
Tests
Signed-off-by: Deepak Jain deepujain@gmail.com