fix(installer): preserve npm lockfiles during install#4029
Conversation
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis PR validates both root and Changesnpm ci & lockfile validation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Comment |
E2E Advisor RecommendationRequired E2E: Dispatch hint: Auto-dispatched E2E: Full advisor summaryE2E Recommendation AdvisorBase: Required E2E
Optional E2E
New E2E recommendations
Dispatch hint
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/install-preflight.test.ts`:
- Around line 98-100: The test harness function writeNpmStub and the
installSnippet handlers are not accounting for npm "ci" invocations, causing
many tests to hit the "unexpected npm invocation: ci --ignore-scripts" path;
update writeNpmStub (and any installSnippet blocks used in
test/install-preflight.test.ts) to accept and handle the "ci" command the same
way as "install" (e.g., add "$1" = "ci" branches or normalize "$1" to "install"
inside the stub) so existing test-specific handlers match the new installer
behavior and no longer reject npm ci.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 175adef9-a9c5-45a2-b6ec-9bed3c4f2f55
📒 Files selected for processing (4)
.github/actions/basic-checks/action.yamlscripts/install.shtest/install-preflight.test.tstest/lockfile-ci-guard.test.ts
| if [ "$1" = "ci" ] || [ "$1" = "install" ] || [ "$1" = "link" ] || [ "$1" = "uninstall" ] || [ "$1" = "pack" ] || [ "$1" = "run" ]; then | ||
| ${installSnippet} | ||
| fi |
There was a problem hiding this comment.
writeNpmStub() still leaves many test-specific handlers rejecting npm ci.
Line 98 now dispatches ci, but a lot of callers in this file still only branch on "$1" = "install" inside installSnippet. Those tests will now fall through to unexpected npm invocation: ci --ignore-scripts, so the suite is still out of sync with the installer change.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@test/install-preflight.test.ts` around lines 98 - 100, The test harness
function writeNpmStub and the installSnippet handlers are not accounting for npm
"ci" invocations, causing many tests to hit the "unexpected npm invocation: ci
--ignore-scripts" path; update writeNpmStub (and any installSnippet blocks used
in test/install-preflight.test.ts) to accept and handle the "ci" command the
same way as "install" (e.g., add "$1" = "ci" branches or normalize "$1" to
"install" inside the stub) so existing test-specific handlers match the new
installer behavior and no longer reject npm ci.
PR Review AdvisorFindings: 0 needs attention, 1 worth checking, 0 nice ideas Review findings🛠️ Needs attention
🔎 Worth checking
🌱 Nice ideas
This is an automated advisory review. A human maintainer must make the final merge decision. |
Selective E2E Results — ✅ All requested jobs passedRun: 26262466547
|
wscurran
added
fix
NemoClaw CLI
|
I checked the failing I did not force-push this PR branch. I pushed a helper branch and opened a helper PR against this branch: Focused local verification from npm_config_cache=/tmp/codex-npm-cache-pr4029 npx vitest run test/install-preflight.test.ts test/lockfile-ci-guard.test.ts --testTimeout 60000
npm run source-shape:check
bash -n scripts/install.sh && git diff --check |
|
Update: helper PR #4203 was auto-closed by the repository's open-PR limit automation, but the helper branch remains pushed:
The branch contains only the |
E2E Scenario Advisor RecommendationRequired scenario E2E: None Full scenario advisor summaryE2E Scenario AdvisorBase: Required scenario E2E
Optional scenario E2E
Relevant changed files
|
Selective E2E Results — ✅ All requested jobs passedRun: 26453121265
|
Selective E2E Results — ✅ All requested jobs passedRun: 26496036613
|
wscurran
added
area: cli
4 participants
Summary
npm installtonpm cifor both the root package and nestednemoclaw/sandbox payload.npm cifor both lockfiles before the install step.npm ci --ignore-scriptswithout global GitHub installs.Supersedes #3840.
Fixes #3798.
Repro
Issue #3798 reproduces when a host-side install mutates the nested sandbox lockfile before the Linux Docker build. On macOS with npm 11.6.2,
cd nemoclaw && npm install --ignore-scriptsprunes Linux-only optional@emnapi/*entries fromnemoclaw/package-lock.json; the subsequent Linuxnode:22-trixie-slimnpm cithen fails with the missing@emnapi/core/@emnapi/runtimeerrors described in the issue.Test Plan
bash -n scripts/install.shgit diff --checknpm test -- test/install-preflight.test.ts test/lockfile-ci-guard.test.ts -t "uses npm ci|lockfile CI guards"(blocked locally:vitest: command not found; this worktree has nonode_modules)Summary by CodeRabbit
Chores
Tests