-
Notifications
You must be signed in to change notification settings - Fork 498
feature: dynamo integration with nat profiler and prometheus/grafana dashboard #1486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bbednarski9
wants to merge
13
commits into
NVIDIA:develop
Choose a base branch
from
bbednarski9:bb/dynamo-router-v1.5
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
01fd95c
forward-compatible register_llm() ETCD registration
bbednarski9 c9c9dca
processor with KVES draft
bbednarski9 3f69607
add monitoring setup and metrics collection
bbednarski9 2d5623d
dynamo profiler integration!
bbednarski9 2fb79db
grafana dash updates
bbednarski9 6c0f2b5
profiler and grafana patches
bbednarski9 2585adc
vllm support and minimal KC cache control test case
bbednarski9 9249b3c
vllm harness for MultiRLU
bbednarski9 58f91e2
ruff checks
bbednarski9 144e30f
sequence diagrams
bbednarski9 25a8bd5
sequence diagrams
bbednarski9 1379b12
sequence diagrams 3
bbednarski9 54e10a1
sequence diagrams 4
bbednarski9 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/NeMo-Agent-Toolkit
Length of output: 239
🏁 Script executed:
Repository: NVIDIA/NeMo-Agent-Toolkit
Length of output: 2835
🏁 Script executed:
# Get line count and read the full file to see export patterns wc -l external/dynamo/.env.example cat -n external/dynamo/.env.exampleRepository: NVIDIA/NeMo-Agent-Toolkit
Length of output: 6718
🏁 Script executed:
Repository: NVIDIA/NeMo-Agent-Toolkit
Length of output: 299
🏁 Script executed:
Repository: NVIDIA/NeMo-Agent-Toolkit
Length of output: 51
🏁 Script executed:
Repository: NVIDIA/NeMo-Agent-Toolkit
Length of output: 161
Add missing
exportstatements and remove quotes for consistency with dotenv conventions.The file uses
exporton some variables (lines 16, 18, 30, 33, 41) but omits it on others (lines 61, 110, 125-126). When sourced, variables withoutexportwon't propagate to child processes. Additionally, line 126 has quotes around the image URL, which is non-standard for.envfiles and can cause parsing issues.Suggested fix
🤖 Prompt for AI Agents