Feature Election contribution#3876
Merged
chesterxgchen merged 236 commits intoNVIDIA:mainfrom Mar 17, 2026
Merged
Conversation
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Removed leftover testing code Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
… Most greptile issues resolved
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
…ng aggregation works correctly in production deployments
…after mask application, and document client_stats exclusion from persistence
…s except block so a workflow exception puts the FL job into a defined abort state rather than silently swallowing the error. - controller.py: wrap stop_controller's JSON file write in try/except OSError so a filesystem failure during teardown is logged but does not propagate and interrupt controller shutdown. - feature_election.py: add empty-client guards (ValueError) to the random and sequential-fallback branches of prepare_data_splits, matching the existing guards in the stratified and dirichlet paths. - feature_election.py: validate that every DataFrame client in simulate_election has the same column labels as the first client; raise ValueError on mismatch instead of silently misaligning feature name reporting.
…tness issues - executor: consistent scaler in tuning eval; ValueError on unknown fs_method; expand PyImpetus fallback warning - controller: skip all-zero client masks in _extract_client_data; plateau early-exit in tuning loop - feature_election: use RandomState (not np.random.seed) in random/non_iid splits; validate params on load_results; plateau early-exit in simulate_election tuning loop
-prepare_data.py uses np.random.seed() (global state) in all three split functions -feature_election.py __init__ doesn't validate tuning_rounds >= 0 -feature_election.py "dirichlet" alias silently converts with no deprecation warning -executor.py _handle_tuning_eval gives no log when tuning_mask is absent from shareable -test.py doesn't validate executor client config args, and has no tests for unknown fs_method, load_results round-trip, or quick_election bad kwargs
Collaborator
|
/build |
Collaborator
|
@christofilojohn the PR merged, thank you for your contribution and patient to go through the PR review process. |
Contributor
Author
|
@chesterxgchen Thank you for the support ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Implemented all the changes you requested on file format, tests etc. black-check, isort-check, flake8 pass.
Types of changes
./runtest.sh.