PR validation: preserve tail output and fix SoB order#422
Open
nirmoy wants to merge 2 commits into
Open
Conversation
When validation output exceeds the PR comment budget, keep both the beginning and end of the captured log instead of only the beginning. This keeps the cherry-pick digest visible while preserving tail metadata errors such as missing Launchpad links. Change-Id: I86a0b8880d90fb51debf17fefa00914a84494da6
For backported-from URL commits, accept the backporter Signed-off-by after the backport trailer instead of requiring an SoB before it. For cherry-pick and backported-from-commit commits, verify added SoB trailers appear after local provenance markers, including [Name: note], (cherry picked from commit ...), and (backported from commit ...). Count duplicate SoB lines so same-author upstream and backporter signatures are still classified by occurrence order. Change-Id: Idbfc36165e6498f58e268fa8d02e77ea59ddb85a
nirmoy
changed the title
Collaborator
Author
Boro reviewLatest watcher review: open review Head: This comment is maintained by nv-pr-bot. It is updated when the GitHub watcher publishes a newer review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #419 exposed that the unified PR Validation Report can truncate a long validate-pr digest before the actionable tail metadata errors.
PR #423 exposed a second issue in the backport trailer check: validate-pr incorrectly required a Signed-off-by before
(backported from ...). The backporter Signed-off-by should be after local provenance trailers:[Name: note],(cherry picked from commit ...),(backported from commit ...), or(backported from ...).This PR now:
(backported from ...)thenSigned-off-byorder.Validation:
python3 -m py_compile .github/scripts/validate-prgit diff --check upstream/github-actions..HEADvalidate-pragainst PR [26.04_linux-nvidia-bos] NVIDIA: SAUCE: ovl: keep err zero after successful ovl_cache_get() #423: passesvalidate-pragainst PR [26.04_linux-nvidia-bos] ats always on v4 #401: passesvalidate-pragainst known-good cherry-pick9ee279dace88: passes(backported from ...)ordering: fails withMISSING: no Signed-off-by after (backported from ...)(cherry picked from commit ...)ordering: fails withORDER: move Signed-off-by after (cherry picked from commit ...)