Skip to content

Ko3n1g/chore/update nightlies #4076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ko3n1g wants to merge 3 commits into from
Closed

Ko3n1g/chore/update nightlies #4076

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58baa0e
chore: Update nightly values
ko3n1g Mar 31, 2026
877cdf8
Revert "Ensure type-checker understands use of Submodules in bert_mod…
ko3n1g Mar 31, 2026
45e570c
update
ko3n1g Mar 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions megatron/core/models/bert/bert_model.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,13 @@
from megatron.core.models.common.embeddings.rotary_pos_embedding import RotaryEmbedding
from megatron.core.models.common.language_module.language_module import LanguageModule
from megatron.core.process_groups_config import ProcessGroupCollection
from megatron.core.transformer.attention import SelfAttentionSubmodules
from megatron.core.transformer.dot_product_attention import (
DotProductAttention as MCoreDotProductAttention,
)
from megatron.core.transformer.enums import AttnBackend, AttnMaskType, ModelType
from megatron.core.transformer.spec_utils import ModuleSpec
from megatron.core.transformer.transformer_block import TransformerBlock
from megatron.core.transformer.transformer_config import TransformerConfig
from megatron.core.transformer.transformer_layer import TransformerLayerSubmodules
from megatron.core.transformer.utils import get_linear_layer
from megatron.core.utils import deprecate_inference_params, is_te_min_version

Expand Down Expand Up @@ -185,11 +183,6 @@ def _sanity_check_attention_and_get_attn_mask_dimension(self) -> str:
"""
attention_backend = self.config.attention_backend
attn_mask_dimensions = None
assert isinstance(self.transformer_layer_spec.submodules, TransformerLayerSubmodules)
assert isinstance(
self.transformer_layer_spec.submodules.self_attention.submodules,
SelfAttentionSubmodules,
)
# For local layer spec we just use b1ss
if (
self.transformer_layer_spec.submodules.self_attention.submodules.core_attention
Expand Down
Loading