Fix THD RoPE offsets for local packed shards#4075
Open
kaimo455 wants to merge 3 commits intoNVIDIA:mainfrom
Open
Fix THD RoPE offsets for local packed shards#4075kaimo455 wants to merge 3 commits intoNVIDIA:mainfrom
kaimo455 wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
/claude review |
Contributor
|
/ok to test ccbd017 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Preserves THD RoPE positions for local packed shards by honoring caller-provided
offsetswhenfreqsonly contains max-sequence positions.It also adds unit regressions for the local packed-shard offset path, the fused THD fallback path when
offsetsare provided, and the conversion of local offset scalars to Pythonintvalues before slicing.Validation run for this PR:
python -m py_compile megatron/core/models/common/embeddings/rope_utils.py tests/unit_tests/transformer/test_rope.pyPYTHONPATH=. uv run --no-project --isolated --with torch --with numpy --with packaging --with click --with requests --with pyyaml --with pytest==8.3.5 python -m pytest tests/unit_tests/transformer/test_rope.py -k 'python_ints or offsets or fusion_when_offsets' -qPYTHONPATH=. uv run --no-project --isolated --with black==24.4.2 --with isort==5.13.2 --with pylint==3.2.6 --with 'ruff~=0.9.0' --with mypy --with torch --with numpy --with packaging --with click --with requests --with pyyaml --with pytest==8.3.5 bash tools/autoformat.shContribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.