Add permute/unpermute fusion with dispatch/combine in Hybrid-EP#4073
Open
Autumn1998 wants to merge 1 commit intoNVIDIA:devfrom
Open
Add permute/unpermute fusion with dispatch/combine in Hybrid-EP#4073Autumn1998 wants to merge 1 commit intoNVIDIA:devfrom
Autumn1998 wants to merge 1 commit intoNVIDIA:devfrom
Conversation
Victarry
reviewed
Mar 31, 2026
| probs=grad_probs, | ||
| handle=handle, | ||
| pad_multiple=ctx.pad_multiple, | ||
| fuse_unpermute_combine=ctx.fused, |
Contributor
There was a problem hiding this comment.
Could we add a version guard to this new API key?
Contributor
Author
There was a problem hiding this comment.
Added a version guard to the buffer initialization function
Autumn1998
force-pushed
the
tongliu_permute_comm_fusion
branch
from
548af5e to
75407d6
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR introduce the new feature: fuse the permute/unpermute with the dispatch/combine into 1 kernel
This feature is provided by the hybrid-ep
related PR in main: #4089
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.