[Dev] Skip routed expert padding for graph-safe MoE#4071
Open
zhongbozhu wants to merge 1 commit intoNVIDIA:devfrom
Open
[Dev] Skip routed expert padding for graph-safe MoE#4071zhongbozhu wants to merge 1 commit intoNVIDIA:devfrom
zhongbozhu wants to merge 1 commit intoNVIDIA:devfrom
Conversation
3d0fd34 to
a10b0cc
Compare
Signed-off-by: Zhongbo Zhu <zhongboz@nvidia.com>
Draft
Contributor
|
LGTM! |
yaox12
approved these changes
Mar 31, 2026
Member
|
/ok to test a10b0cc |
|
🔄 Merge queue validation started! You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23793449235 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR is a follow up fix to #3890, which introduced TE Fused group mlp layer for graph safe moe. However, padding itself as a stand-alone operation can also be graph-unsafe if the padding was implemented based on knowing problem shapes on host, which is the case for router padding and explicit Fp8Padding module.
HybridEp provides the ability of doing the padding fused with local permute, which is done on-device, so it's cuda graph safe. This PR checks whether padding has already been done so that we can safely skip the graph-unsafe padding, this will be used together with the paged stashing PR: #2690.
PR to main: TBD (waiting on #3971 to be merged to main)
Contribution process
Pre-checks
Code review
Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of mcore-engineers will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.