Fix DSA indexer loss not averaged across micro-batches#4070
Open
kaimo455 wants to merge 2 commits intoNVIDIA:mainfrom
Open
Fix DSA indexer loss not averaged across micro-batches#4070kaimo455 wants to merge 2 commits intoNVIDIA:mainfrom
kaimo455 wants to merge 2 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
This PR has been automatically converted to draft because all PRs must start as drafts. When you are ready for review, click Ready for Review to begin the review process. This will:
See the contribution guide for more details. |
Author
|
@mcore-oncall PR #4070 is ready for review. Could you help with vetting so CI can complete on NVIDIA runners? Thanks! |
Contributor
|
/ok to test 47764ce |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes DSA indexer loss scaling so it is consistent across micro-batches under gradient accumulation.
Background
DSA injects the indexer loss into the main loss backward pass via
DSAIndexerLossAutoScaler. When Megatron is not calculating per-token loss, the main loss is reduced by1 / num_microbatches, and other auxiliary losses (e.g., MTP) are scaled similarly.Previously, the DSA indexer loss scale was not normalized by
num_microbatches, so gradients changed asnum_microbatcheschanged.Change
Set
DSAIndexerLossAutoScaler's loss scale toloss_scale / num_microbatcheswhencalculate_per_token_lossis false, matching the existing scaling pattern used by MTP.Validation
num_microbatches=1andnum_microbatches>1.calculate_per_token_lossis true.cc @mcore-oncall (vetting needed so CI can run)
Contribution process
Pre-checks
Code review
Feel free to message or comment the [@mcore-oncall](https://github.com/orgs/NVIDIA/teams/mcore-oncall) to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!
All PRs start as draft. If you open a non-draft PR, it will be automatically converted to draft.
Step 1: Mark PR as "Ready for Review"
.github/CODEOWNERS.Final Review might get declined if these requirements are not fulfilled.
Step 2: Final Review
For PRs that change
megatron/core, once all expert reviewers have approved, theFinal Reviewlabel is applied automatically and final reviewers are assigned.For PRs outside
megatron/core, this step is skipped.Step 3: Approved
Once all required reviewers have approved, the
Approvedlabel is applied automatically.Merge
Any member of [mcore-engineers](https://github.com/orgs/NVIDIA/teams/mcore-engineers) will be able to merge your PR.
For MRs into `dev` branch
The proposed review process for `dev` branch is under active discussion.MRs are mergable after one approval by either
eharper@nvidia.comorzijiey@nvidia.com.