Skip to content

feat(scheduler): Add gpu dra accounting #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
davidLif wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat(scheduler): Add gpu dra accounting #900

davidLif wants to merge 16 commits into from

Conversation

@davidLif
Copy link
Collaborator

@davidLif davidLif commented Jan 19, 2026 •
edited
Loading

Description

1- Add extra integration tests for dra reclaim and allocate.
2- Fix integration tests utils to properly support DRA
3- Count Gpu resourceSlices for fairShare
4- Resource structs contain gpu dra counters as a separate field
5- Small common dra utils refactor
6- Added the gpu DRA claims counters to the GetGpusQuota function, to make sure that gpu DRA claims are reflected in the gpu accounting calculations, but not in the extended resource comparison.
7- Added the option to set up an e2e cluster with fake DRA gpus for testing

This DOES NOT support:
1- Gpu DRA claims with FirstAvailable
2- Gpu DRA claims shared by several pods

Related Issues

Fixes #

Checklist

Note: Ensure your PR title follows the Conventional Commits format (e.g., feat(scheduler): add new feature)

  • Self-reviewed
  • Added/updated tests (if needed)
  • Updated documentation (if needed)

Breaking Changes

Additional Notes

@davidLif davidLif force-pushed the DavidL/35314/master branch from aacfcd7 to 82689aa Compare January 19, 2026 19:27
@github-actions
Copy link

github-actions bot commented Jan 19, 2026 •
edited
Loading

📊 Performance Benchmark Results

Comparing PR (DavidL/35314/master) vs main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
                                    │ main-bench.txt │           pr-bench.txt            │
                                    │     sec/op     │   sec/op     vs base              │
AllocateAction_SmallCluster-4           107.9m ±  0%   108.0m ± 9%       ~ (p=0.394 n=6)
AllocateAction_MediumCluster-4          135.1m ±  2%   135.5m ± 2%       ~ (p=0.485 n=6)
AllocateAction_LargeCluster-4           211.5m ± 16%   227.0m ± 7%       ~ (p=0.132 n=6)
ReclaimAction_SmallCluster-4            102.8m ±  0%   102.8m ± 0%       ~ (p=0.818 n=6)
ReclaimAction_MediumCluster-4           105.6m ±  0%   105.4m ± 0%       ~ (p=0.065 n=6)
PreemptAction_SmallCluster-4            103.7m ±  0%   103.7m ± 0%       ~ (p=0.937 n=6)
PreemptAction_MediumCluster-4           112.8m ±  0%   113.1m ± 0%  +0.26% (p=0.002 n=6)
ConsolidationAction_SmallCluster-4      113.3m ±  0%   113.7m ± 0%  +0.34% (p=0.002 n=6)
ConsolidationAction_MediumCluster-4     200.8m ±  1%   201.7m ± 1%       ~ (p=0.240 n=6)
FullSchedulingCycle_SmallCluster-4      105.1m ±  0%   105.0m ± 0%       ~ (p=0.180 n=6)
FullSchedulingCycle_MediumCluster-4     118.9m ±  0%   118.8m ± 0%       ~ (p=0.180 n=6)
FullSchedulingCycle_LargeCluster-4      156.6m ±  1%   156.9m ± 1%       ~ (p=0.394 n=6)
ManyQueues_MediumCluster-4              139.0m ±  1%   138.1m ± 2%       ~ (p=0.310 n=6)
GangScheduling_MediumCluster-4          156.5m ±  1%   157.2m ± 1%       ~ (p=0.132 n=6)
geomean                                 129.7m         130.4m       +0.58%

                                    │ main-bench.txt │            pr-bench.txt             │
                                    │      B/op      │     B/op       vs base              │
AllocateAction_SmallCluster-4           2.116Mi ± 1%    2.153Mi ± 1%  +1.75% (p=0.002 n=6)
AllocateAction_MediumCluster-4          11.70Mi ± 0%    11.84Mi ± 0%  +1.25% (p=0.002 n=6)
AllocateAction_LargeCluster-4           41.17Mi ± 0%    41.54Mi ± 0%  +0.89% (p=0.002 n=6)
ReclaimAction_SmallCluster-4            867.4Ki ± 1%    889.1Ki ± 1%  +2.50% (p=0.002 n=6)
ReclaimAction_MediumCluster-4           2.738Mi ± 0%    2.828Mi ± 0%  +3.27% (p=0.002 n=6)
PreemptAction_SmallCluster-4           1010.5Ki ± 1%   1031.1Ki ± 1%  +2.04% (p=0.002 n=6)
PreemptAction_MediumCluster-4           3.947Mi ± 0%    4.018Mi ± 0%  +1.80% (p=0.002 n=6)
ConsolidationAction_SmallCluster-4      5.549Mi ± 0%    5.602Mi ± 0%  +0.96% (p=0.002 n=6)
ConsolidationAction_MediumCluster-4     46.67Mi ± 0%    46.88Mi ± 0%  +0.46% (p=0.002 n=6)
FullSchedulingCycle_SmallCluster-4      1.343Mi ± 1%    1.372Mi ± 0%  +2.17% (p=0.002 n=6)
FullSchedulingCycle_MediumCluster-4     6.717Mi ± 0%    6.836Mi ± 0%  +1.77% (p=0.002 n=6)
FullSchedulingCycle_LargeCluster-4      22.53Mi ± 0%    22.83Mi ± 0%  +1.32% (p=0.002 n=6)
ManyQueues_MediumCluster-4              16.16Mi ± 0%    16.30Mi ± 0%  +0.90% (p=0.002 n=6)
GangScheduling_MediumCluster-4          16.88Mi ± 0%    17.17Mi ± 0%  +1.74% (p=0.002 n=6)
geomean                                 6.228Mi         6.329Mi       +1.63%

                                    │ main-bench.txt │           pr-bench.txt            │
                                    │   allocs/op    │  allocs/op   vs base              │
AllocateAction_SmallCluster-4            35.40k ± 0%   36.21k ± 0%  +2.27% (p=0.002 n=6)
AllocateAction_MediumCluster-4           322.0k ± 0%   325.2k ± 0%  +0.99% (p=0.002 n=6)
AllocateAction_LargeCluster-4            1.386M ± 0%   1.394M ± 0%  +0.58% (p=0.002 n=6)
ReclaimAction_SmallCluster-4             7.896k ± 0%   8.395k ± 0%  +6.32% (p=0.002 n=6)
ReclaimAction_MediumCluster-4            24.54k ± 0%   26.54k ± 0%  +8.15% (p=0.002 n=6)
PreemptAction_SmallCluster-4             10.79k ± 0%   11.19k ± 0%  +3.71% (p=0.002 n=6)
PreemptAction_MediumCluster-4            37.17k ± 0%   38.77k ± 0%  +4.30% (p=0.002 n=6)
ConsolidationAction_SmallCluster-4       72.34k ± 0%   73.55k ± 0%  +1.67% (p=0.002 n=6)
ConsolidationAction_MediumCluster-4      681.1k ± 0%   685.8k ± 0%  +0.70% (p=0.002 n=6)
FullSchedulingCycle_SmallCluster-4       20.71k ± 0%   21.36k ± 0%  +3.12% (p=0.002 n=6)
FullSchedulingCycle_MediumCluster-4      172.1k ± 0%   174.7k ± 0%  +1.51% (p=0.002 n=6)
FullSchedulingCycle_LargeCluster-4       720.8k ± 0%   727.3k ± 0%  +0.90% (p=0.002 n=6)
ManyQueues_MediumCluster-4               360.1k ± 0%   363.3k ± 0%  +0.89% (p=0.002 n=6)
GangScheduling_MediumCluster-4           590.6k ± 0%   597.0k ± 0%  +1.08% (p=0.002 n=6)
geomean                                  108.9k        111.7k       +2.56%

Legend

  • 📉 Negative delta = Performance improvement (faster)
  • 📈 Positive delta = Performance regression (slower)
  • p-value < 0.05 indicates statistically significant change
Raw benchmark data

PR branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	       9	 117433538 ns/op	 2278216 B/op	   36222 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108331220 ns/op	 2256073 B/op	   36208 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 108085468 ns/op	 2256098 B/op	   36203 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107698295 ns/op	 2257178 B/op	   36208 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107782447 ns/op	 2257130 B/op	   36205 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107972252 ns/op	 2266904 B/op	   36205 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136626294 ns/op	12436207 B/op	  325195 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134237392 ns/op	12418171 B/op	  325186 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134294925 ns/op	12416375 B/op	  325189 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136425530 ns/op	12416975 B/op	  325192 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 138596020 ns/op	12415949 B/op	  325184 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134587637 ns/op	12415811 B/op	  325183 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 230989060 ns/op	43559360 B/op	 1394311 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 238581326 ns/op	43558532 B/op	 1394310 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 226862702 ns/op	43555576 B/op	 1394283 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 227076276 ns/op	43557945 B/op	 1394298 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 211916518 ns/op	43562505 B/op	 1394272 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 221058240 ns/op	43557091 B/op	 1394294 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102781974 ns/op	  905424 B/op	    8368 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102816551 ns/op	  906552 B/op	    8383 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102944095 ns/op	  914269 B/op	    8398 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102891197 ns/op	  914250 B/op	    8397 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102802091 ns/op	  906485 B/op	    8394 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102786694 ns/op	  915240 B/op	    8396 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105545973 ns/op	 2965442 B/op	   26538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105158533 ns/op	 2969479 B/op	   26539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105286432 ns/op	 2965680 B/op	   26539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105566097 ns/op	 2961610 B/op	   26536 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105449888 ns/op	 2965532 B/op	   26538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105407992 ns/op	 2965445 B/op	   26537 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103506880 ns/op	 1056031 B/op	   11189 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103696764 ns/op	 1055896 B/op	   11188 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103701038 ns/op	 1055938 B/op	   11188 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103693236 ns/op	 1055799 B/op	   11188 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103554856 ns/op	 1054524 B/op	   11185 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103620892 ns/op	 1048164 B/op	   11186 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113126677 ns/op	 4215263 B/op	   38771 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113049106 ns/op	 4210587 B/op	   38768 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113130138 ns/op	 4210984 B/op	   38770 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113013987 ns/op	 4206520 B/op	   38768 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113481350 ns/op	 4215305 B/op	   38771 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 113186852 ns/op	 4215145 B/op	   38770 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113670332 ns/op	 5875224 B/op	   73555 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 114022807 ns/op	 5874703 B/op	   73551 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113676482 ns/op	 5874185 B/op	   73548 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113903164 ns/op	 5886792 B/op	   73589 allocs/op

Main branch:

goos: linux
goarch: amd64
pkg: github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions
cpu: AMD EPYC 7763 64-Core Processor                
BenchmarkAllocateAction_SmallCluster-4         	      10	 108089378 ns/op	 2237913 B/op	   35413 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107901367 ns/op	 2219973 B/op	   35398 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107876860 ns/op	 2217738 B/op	   35405 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107757055 ns/op	 2218271 B/op	   35401 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107948959 ns/op	 2218361 B/op	   35405 allocs/op
BenchmarkAllocateAction_SmallCluster-4         	      10	 107760466 ns/op	 2215689 B/op	   35400 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 134538013 ns/op	12266005 B/op	  321996 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 137019449 ns/op	12263195 B/op	  321989 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133006288 ns/op	12264471 B/op	  321996 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 133693379 ns/op	12262752 B/op	  321986 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 136030003 ns/op	12263396 B/op	  321993 allocs/op
BenchmarkAllocateAction_MediumCluster-4        	       8	 135735561 ns/op	12265716 B/op	  321984 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 223089984 ns/op	43172910 B/op	 1386293 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 209379540 ns/op	43173294 B/op	 1386295 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 209013822 ns/op	43170739 B/op	 1386275 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 244523074 ns/op	43172009 B/op	 1386280 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 211767450 ns/op	43171184 B/op	 1386280 allocs/op
BenchmarkAllocateAction_LargeCluster-4         	       5	 211261606 ns/op	43173225 B/op	 1386298 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102810028 ns/op	  877298 B/op	    7864 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102779097 ns/op	  882413 B/op	    7881 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102829944 ns/op	  890178 B/op	    7897 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102876383 ns/op	  890208 B/op	    7898 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102783111 ns/op	  891136 B/op	    7896 allocs/op
BenchmarkReclaimAction_SmallCluster-4          	      10	 102865451 ns/op	  886269 B/op	    7896 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105776605 ns/op	 2873424 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105303313 ns/op	 2873444 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105608802 ns/op	 2865612 B/op	   24536 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105642770 ns/op	 2869544 B/op	   24538 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105575359 ns/op	 2873375 B/op	   24539 allocs/op
BenchmarkReclaimAction_MediumCluster-4         	      10	 105523628 ns/op	 2865564 B/op	   24536 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103426706 ns/op	 1032727 B/op	   10787 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103789969 ns/op	 1036709 B/op	   10788 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103685904 ns/op	 1036751 B/op	   10789 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103611784 ns/op	 1043520 B/op	   10790 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103678042 ns/op	 1032716 B/op	   10787 allocs/op
BenchmarkPreemptAction_SmallCluster-4          	      10	 103638896 ns/op	 1032812 B/op	   10787 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112977078 ns/op	 4138564 B/op	   37172 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112877278 ns/op	 4134091 B/op	   37170 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112795042 ns/op	 4138418 B/op	   37171 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112868370 ns/op	 4129666 B/op	   37168 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112776897 ns/op	 4138495 B/op	   37171 allocs/op
BenchmarkPreemptAction_MediumCluster-4         	       9	 112633024 ns/op	 4138592 B/op	   37172 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 112855608 ns/op	 5826738 B/op	   72429 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113297238 ns/op	 5814809 B/op	   72338 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113179149 ns/op	 5825776 B/op	   72352 allocs/op
BenchmarkConsolidationAction_SmallCluster-4    	       9	 113290137 ns/op	 5822795 B/op	   72397 allocs/op

@davidLif davidLif force-pushed the DavidL/35314/master branch from bc294e1 to 71fb510 Compare January 20, 2026 08:29
@github-actions
Copy link

github-actions bot commented Jan 20, 2026

Merging this branch changes the coverage (5 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources 57.64% (+2.39%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils 56.48% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info 63.21% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info 66.82% (+0.08%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info 58.97% (-0.40%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 60.12% (-0.25%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info 39.59% (-4.26%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info 83.45% (-0.55%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources 33.85% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion 34.17% (-2.82%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy 98.59% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra.go 92.75% (+4.52%) 69 (+1) 64 (+4) 5 (-3) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils/integration_tests_utils.go 0.00% (ø) 66 (+10) 0 66 (+10)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info/pod_errors.go 44.57% (ø) 92 41 51
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info/node_info.go 63.14% (+0.13%) 293 (+1) 185 (+1) 108 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info/pod_info.go 49.61% (-0.39%) 127 (+3) 63 (+1) 64 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/allocation_info.go 85.37% (-1.98%) 82 (+3) 70 (+1) 12 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/gpu_resource_requirment.go 61.33% (-9.63%) 75 (+13) 46 (+2) 29 (+11) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_info.go 0.00% (ø) 95 (+20) 0 95 (+20)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_requirment.go 53.73% (ø) 67 36 31
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info.go 85.43% (-1.06%) 254 (+17) 217 (+12) 37 (+5) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/data_lister_mock.go 0.00% (ø) 116 (+7) 0 116 (+7)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/interface.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/kubernetes_lister.go 0.00% (ø) 19 (+1) 0 19 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources.go 33.85% (ø) 130 44 86
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy/capacity_policy.go 100.00% (ø) 25 25 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/proportion.go 34.17% (-2.82%) 240 (+21) 82 (+1) 158 (+20) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils/utils.go 0.00% (ø) 3 0 3
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake/dra.go 0.00% (ø) 4 0 4
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake/jobs.go 0.00% (ø) 141 (+15) 0 141 (+15)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/test_utils_builder.go 0.00% (ø) 114 (+2) 0 114 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra_gpu_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate/allocate_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim/reclaim_gpu_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils/job_order_by_queue_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources_test.go

@davidLif davidLif force-pushed the DavidL/35314/master branch from 71fb510 to aacb5bd Compare January 25, 2026 12:50
@github-actions
Copy link

github-actions bot commented Jan 25, 2026

Merging this branch changes the coverage (5 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources 57.64% (+2.39%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils 56.48% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info 63.21% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info 66.82% (+0.08%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info 58.97% (-0.40%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 60.12% (-0.25%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info 39.59% (-4.26%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info 83.45% (-0.55%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources 33.85% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion 34.17% (-2.82%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy 98.59% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra.go 92.75% (+4.52%) 69 (+1) 64 (+4) 5 (-3) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils/integration_tests_utils.go 0.00% (ø) 66 (+10) 0 66 (+10)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info/pod_errors.go 44.57% (ø) 92 41 51
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info/node_info.go 63.14% (+0.13%) 293 (+1) 185 (+1) 108 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info/pod_info.go 49.61% (-0.39%) 127 (+3) 63 (+1) 64 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/allocation_info.go 85.37% (-1.98%) 82 (+3) 70 (+1) 12 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/gpu_resource_requirment.go 61.33% (-9.63%) 75 (+13) 46 (+2) 29 (+11) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_info.go 0.00% (ø) 95 (+20) 0 95 (+20)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_requirment.go 53.73% (ø) 67 36 31
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info.go 85.43% (-1.06%) 254 (+17) 217 (+12) 37 (+5) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/data_lister_mock.go 0.00% (ø) 116 (+7) 0 116 (+7)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/interface.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/kubernetes_lister.go 0.00% (ø) 19 (+1) 0 19 (+1)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources.go 33.85% (ø) 130 44 86
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy/capacity_policy.go 100.00% (ø) 25 25 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/proportion.go 34.17% (-2.82%) 240 (+21) 82 (+1) 158 (+20) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils/utils.go 0.00% (ø) 3 0 3
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake/dra.go 0.00% (ø) 4 0 4
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake/jobs.go 0.00% (ø) 141 (+15) 0 141 (+15)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/test_utils_builder.go 0.00% (ø) 114 (+2) 0 114 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra_gpu_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate/allocate_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim/reclaim_gpu_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils/job_order_by_queue_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources_test.go

@davidLif
1- Changed the resource objects in the scheduler to include a gpu DRA…
a0c5810 
… claims counter section

2- Added a DRA claim lister to the scheduler. DID NOT update the snapshot accordingly.
3- Added the gpu DRA claims counters to the GetGpusQuota function, to make sure that gpu DRA claims are reflected in the gpu accounting calculations, but not in the extended resource comparison.
4- Added the option to set up an e2e cluster with fake DRA gpus for testing
@davidLif
Add gpu dra accounting:
295401d 
1- Add extra integration tests for dra reclaim and allocate.
2- Fix integration tests utils to properly support DRA
3- Count Gpu resourceSlices for fairShare
4- Resource structs contain gpu dra counters as a separate field
5- Small common dra utils refactor

This DOES NOT support:
1- Gpu DRA claims with FirstAvailable
2- Gpu DRA claims shared by several pods
@davidLif
Update changelog
e1ea189
@davidLif davidLif force-pushed the DavidL/35314/master branch from aacb5bd to e1ea189 Compare January 27, 2026 09:01
@github-actions
Copy link

github-actions bot commented Jan 27, 2026

Merging this branch changes the coverage (6 decrease, 1 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources 56.74% (+1.49%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils 56.48% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info 63.21% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info 66.21% (-0.54%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info 58.97% (-0.40%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 60.12% (-0.25%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info 39.59% (-4.26%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info 83.07% (-0.93%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources 33.85% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion 34.17% (-2.82%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy 98.59% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra.go 92.42% (+4.19%) 66 (-2) 61 (+1) 5 (-3) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils/integration_tests_utils.go 0.00% (ø) 66 (+10) 0 66 (+10)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info/pod_errors.go 44.57% (ø) 92 41 51
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info/node_info.go 62.29% (-0.72%) 297 (+5) 185 (+1) 112 (+4) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info/pod_info.go 49.61% (-0.39%) 127 (+3) 63 (+1) 64 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/allocation_info.go 85.37% (-1.98%) 82 (+3) 70 (+1) 12 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/gpu_resource_requirment.go 61.33% (-9.63%) 75 (+13) 46 (+2) 29 (+11) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_info.go 0.00% (ø) 95 (+20) 0 95 (+20)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_requirment.go 53.73% (ø) 67 36 31
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info.go 84.67% (-1.83%) 274 (+37) 232 (+27) 42 (+10) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/data_lister_mock.go 0.00% (ø) 130 (+21) 0 130 (+21)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/interface.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/kubernetes_lister.go 0.00% (ø) 31 (+13) 0 31 (+13)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources.go 33.85% (ø) 130 44 86
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy/capacity_policy.go 100.00% (ø) 25 25 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/proportion.go 34.17% (-2.82%) 240 (+21) 82 (+1) 158 (+20) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils/utils.go 0.00% (ø) 3 0 3
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake/dra.go 0.00% (ø) 4 0 4
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake/jobs.go 0.00% (ø) 141 (+15) 0 141 (+15)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/test_utils_builder.go 0.00% (ø) 114 (+2) 0 114 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra_gpu_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate/allocate_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim/reclaim_gpu_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils/job_order_by_queue_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources_test.go

SiorMeir
SiorMeir reviewed Jan 28, 2026
View reviewed changes
@davidLif
1- Update changelog with the unsupported types message
878a359 
2- Do not add a draGpuCounts count to the resource object (count as float gpus)
3- Update the integration test utils to incorporate node slices.
@davidLif
Remove double dra claims lister
05f8152
@davidLif
Merge branch 'main' into DavidL/35314/master
9b17383
@davidLif davidLif enabled auto-merge January 28, 2026 21:05
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Merging this branch changes the coverage (4 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources 56.74% (+2.45%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils 56.48% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info 63.21% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info 66.28% (+0.16%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info 58.97% (-0.40%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 60.12% (-0.25%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info 41.13% (-2.71%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info 83.10% (-0.47%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources 33.85% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy 98.59% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/nodes_fake 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra.go 92.42% (+4.73%) 66 (+1) 61 (+4) 5 (-3) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils/integration_tests_utils.go 0.00% (ø) 66 (+10) 0 66 (+10)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info/pod_errors.go 44.57% (ø) 92 41 51
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info/gpu_sharing_node_info.go 74.82% (+0.18%) 139 (+1) 104 (+1) 35 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info/node_info.go 62.29% (+0.13%) 297 (+1) 185 (+1) 112 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info/pod_info.go 49.61% (-0.39%) 127 (+3) 63 (+1) 64 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/allocation_info.go 85.37% (-1.98%) 82 (+3) 70 (+1) 12 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/gpu_resource_requirment.go 58.23% (-12.74%) 79 (+17) 46 (+2) 33 (+15) 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_info.go 0.00% (ø) 80 (+5) 0 80 (+5)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_requirment.go 53.73% (ø) 67 36 31
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info.go 84.76% (-0.84%) 269 (+12) 228 (+8) 41 (+4) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/interface.go 0.00% (ø) 0 0 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/kubernetes_lister.go 0.00% (ø) 30 0 30
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources.go 33.85% (ø) 130 44 86
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy/capacity_policy.go 100.00% (ø) 25 25 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils/utils.go 0.00% (ø) 3 0 3
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake/dra.go 0.00% (ø) 4 0 4
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake/jobs.go 0.00% (ø) 141 (+15) 0 141 (+15)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/nodes_fake/nodes.go 0.00% (ø) 73 (+16) 0 73 (+16)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/test_utils_builder.go 0.00% (ø) 114 (+2) 0 114 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra_gpu_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate/allocate_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim/reclaim_gpu_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils/job_order_by_queue_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources_test.go

SiorMeir
SiorMeir reviewed Jan 29, 2026
View reviewed changes
SiorMeir
SiorMeir reviewed Jan 29, 2026
View reviewed changes
SiorMeir
SiorMeir reviewed Jan 29, 2026
View reviewed changes
enoodle
enoodle reviewed Jan 29, 2026
View reviewed changes
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Merging this branch changes the coverage (4 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources 56.74% (+2.45%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils 56.48% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info 63.21% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info 66.28% (+0.16%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info 58.97% (-0.40%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 60.12% (-0.25%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info 41.13% (-2.71%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info 83.10% (-0.47%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources 33.85% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy 98.59% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/nodes_fake 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra.go 92.42% (+4.73%) 66 (+1) 61 (+4) 5 (-3) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils/integration_tests_utils.go 0.00% (ø) 66 (+10) 0 66 (+10)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/common_info/pod_errors.go 44.57% (ø) 92 41 51
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info/gpu_sharing_node_info.go 74.82% (+0.18%) 139 (+1) 104 (+1) 35 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info/node_info.go 62.29% (+0.13%) 297 (+1) 185 (+1) 112 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info/pod_info.go 49.61% (-0.39%) 127 (+3) 63 (+1) 64 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/allocation_info.go 85.37% (-1.98%) 82 (+3) 70 (+1) 12 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/gpu_resource_requirment.go 58.23% (-12.74%) 79 (+17) 46 (+2) 33 (+15) 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_info.go 0.00% (ø) 80 (+5) 0 80 (+5)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_requirment.go 53.73% (ø) 67 36 31
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info.go 84.76% (-0.84%) 269 (+12) 228 (+8) 41 (+4) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/kubernetes_lister.go 0.00% (ø) 30 0 30
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources.go 33.85% (ø) 130 44 86
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy/capacity_policy.go 100.00% (ø) 25 25 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils/utils.go 0.00% (ø) 3 0 3
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake/dra.go 0.00% (ø) 4 0 4
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake/jobs.go 0.00% (ø) 141 (+15) 0 141 (+15)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/nodes_fake/nodes.go 0.00% (ø) 73 (+16) 0 73 (+16)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/test_utils_builder.go 0.00% (ø) 114 (+2) 0 114 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra_gpu_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate/allocate_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim/reclaim_gpu_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils/job_order_by_queue_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources_test.go

enoodle
enoodle previously approved these changes Jan 29, 2026
View reviewed changes
@davidLif
1- Fix DRA env-test
4156c41 
2- Update fake gpu operator in hack/setup-e2e-cluster.sh
@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Merging this branch changes the coverage (5 decrease, 2 increase)

Impacted Packages Coverage Δ 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources 56.74% (+2.45%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/env-tests 75.68% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/dynamicresource 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/common 23.11% (-0.31%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils 56.48% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info 69.25% (+0.14%) 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info 58.97% (-0.40%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info 60.12% (-0.25%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info 40.85% (-3.00%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info 80.35% (-3.10%) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources 33.85% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy 98.59% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake 0.00% (ø)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/nodes_fake 0.00% (ø)
Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra.go 92.42% (+4.73%) 66 (+1) 61 (+4) 5 (-3) 👍
github.com/NVIDIA/KAI-scheduler/pkg/env-tests/dynamicresource/dynamicresource.go 0.00% (ø) 17 0 17
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/common/allocate.go 0.00% (ø) 123 (+3) 0 123 (+3)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/integration_tests_utils/integration_tests_utils.go 0.00% (ø) 66 (+10) 0 66 (+10)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info/gpu_sharing_node_info.go 74.82% (+0.18%) 139 (+1) 104 (+1) 35 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/node_info/node_info.go 66.67% (+0.11%) 300 (+1) 200 (+1) 100 👍
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/pod_info/pod_info.go 49.61% (-0.39%) 127 (+3) 63 (+1) 64 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/podgroup_info/allocation_info.go 85.37% (-1.98%) 82 (+3) 70 (+1) 12 (+2) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/gpu_resource_requirment.go 56.79% (-14.18%) 81 (+19) 46 (+2) 35 (+17) 💀
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_info.go 0.00% (ø) 80 (+5) 0 80 (+5)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/api/resource_info/resource_requirment.go 53.73% (ø) 67 36 31
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info.go 80.34% (-5.05%) 295 (+35) 237 (+15) 58 (+20) 👎
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/data_lister/kubernetes_lister.go 0.00% (ø) 30 0 30
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources.go 33.85% (ø) 130 44 86
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/capacity_policy/capacity_policy.go 100.00% (ø) 25 25 0
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/proportion/utils/utils.go 0.00% (ø) 3 0 3
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/dra_fake/dra.go 0.00% (ø) 4 0 4
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/jobs_fake/jobs.go 0.00% (ø) 141 (+15) 0 141 (+15)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/nodes_fake/nodes.go 0.00% (ø) 73 (+16) 0 73 (+16)
github.com/NVIDIA/KAI-scheduler/pkg/scheduler/test_utils/test_utils_builder.go 0.00% (ø) 114 (+2) 0 114 (+2)

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/NVIDIA/KAI-scheduler/pkg/common/resources/dra_gpu_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/env-tests/scheduler_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/allocate/allocate_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/integration_tests/reclaim/reclaim_gpu_dra_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/actions/utils/job_order_by_queue_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/cache/cluster_info/cluster_info_test.go
  • github.com/NVIDIA/KAI-scheduler/pkg/scheduler/plugins/dynamicresources/dynamicresources_test.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@SiorMeir SiorMeir SiorMeir left review comments

@enoodle enoodle enoodle left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@davidLif @enoodle @SiorMeir