Convert local includes in multidevice tests to quote style

[wujingyue]

• Convert local includes in multidevice tests to quote style
• Reorder include blocks to match Google C++ include ordering
• Add blank lines between third-party include groups and drop unused torch include

[wujingyue]

!test

[github-actions]

Review updated until commit b266da7

Auto-merge Status

✅ Internal CI is finished
❌ No failed checks (nvfuser-ci/jit_python_tests_20_GB200, nvfuser-ci/jit_binary_tests_20_GB200_3/3, clang-build-23)
✅ PR is mergeable
ℹ️ PR mergeable_state: unstable

Description

• Convert local includes from angle brackets to quote style across all multidevice test files

• Reorganize include blocks following Google C++ include ordering guidelines

• Move project-specific includes to top, followed by third-party and system includes

• Add proper blank lines between include groups for better readability

Changes walkthrough

Relevant files

Formatting

18 files multidevice.cpp Convert includes to quote style and reorder                            +12/-11  multidevice_transformer.cpp Convert includes to quote style and reorder                            +8/-7      test_multidevice_communications.cpp Convert includes to quote style and reorder                            +14/-14  test_multidevice_communicator.cpp Convert includes to quote style and reorder                            +2/-2      test_multidevice_host_ir.cpp Convert includes to quote style and reorder                            +8/-8      test_multidevice_host_ir_overlap.cpp Convert includes to quote style and reorder                            +8/-8      test_multidevice_ipc.cpp Convert includes to quote style and reorder                            +9/-8      test_multidevice_lower_communication.cpp Convert includes to quote style and reorder                            +10/-11  test_multidevice_lower_communication_cuda.cpp Convert includes to quote style and reorder                            +13/-13  test_multidevice_matmul.cpp Convert includes to quote style and reorder                            +16/-16  test_multidevice_pipeline.cpp Convert includes to quote style and reorder                            +30/-32  test_multidevice_sharding.cpp Convert includes to quote style and reorder                            +8/-8      test_multidevice_stream_parallel_type.cpp Convert includes to quote style and reorder                            +11/-11  test_multidevice_symmetric_tensor.cpp Convert includes to quote style and reorder                            +2/-2      test_multidevice_transformer.cpp Convert includes to quote style and reorder                            +6/-6      test_multidevice_tutorial.cpp Convert includes to quote style and reorder                            +8/-8      multidevice.h Convert includes to quote style and reorder                            +6/-6      multidevice_transformer.h Convert includes to quote style and reorder                            +1/-1

PR Reviewer Guide

Here are some key observations to aid the review process:

🧪 PR contains tests

🔒 No security concerns identified

⚡ Recommended focus areas for review

[greptile-apps]

Greptile Summary

This PR standardizes include styles across all 18 multidevice test files by converting local project includes from angle bracket style (#include <path/file.h>) to quote style (#include "path/file.h") and reordering them to follow Google C++ include ordering conventions. The changes align with the project's clang-format configuration which specifies SortIncludes: true and include category priorities that treat angle brackets as system/third-party headers and quotes as local project headers.

The PR makes purely mechanical/style changes with no functional modifications:

• Converts all local project includes to quote style across all files
• Reorders include blocks to follow: self-includes → system headers → third-party headers → project headers
• Adds appropriate blank lines between include groups per Google C++ style guide
• Drops unused torch includes where applicable

All 172 insertions and 172 deletions represent include statement reformatting only.

Confidence Score: 5/5

• This PR is safe to merge with no risk—it contains only mechanical include style and ordering changes with no functional impact.
• Score of 5 is justified because: (1) All changes are purely mechanical include reformatting with zero functional modifications; (2) Changes are consistent across all 18 files with no exceptions or edge cases; (3) The modifications align perfectly with the project's clang-format configuration (SortIncludes: true with defined include categories); (4) No includes are removed or added incorrectly—only style and order changes; (5) The Google C++ style guide includes ordering is a well-established best practice; (6) All files maintain the same include set, ensuring no compilation issues; (7) This is a straightforward style normalization that has been applied uniformly across the entire multidevice test suite.
• No files require special attention. All 18 files have been updated consistently and correctly.

Important Files Changed

Filename	Overview
tests/cpp/multidevice.cpp	Converted angle brackets to quotes for local includes and reordered to follow Google C++ include ordering (self-include first, then system headers, then project headers).
tests/cpp/multidevice.h	Converted all project local includes from angle brackets to quotes, following the configured include style.
tests/cpp/test_multidevice_lower_communication_cuda.cpp	Reordered includes with proper grouping and converted local includes to quote style, following Google C++ include ordering standards.
tests/cpp/test_multidevice_pipeline.cpp	Reordered and converted all local includes to quote style, properly grouping includes and removing unnecessary blank lines.

Sequence Diagram

sequenceDiagram
    participant File as Test File
    participant SelfH as Self Header
    participant SysH as System Headers
    participant ThirdP as Third-Party Headers
    participant ProjH as Project Headers

    File->>SelfH: #include "self.h"
    Note over File,SelfH: (if applicable, first)
    
    File->>SysH: #include &lt;sys/types.h&gt;<br/>#include &lt;unistd.h&gt;
    Note over File,SysH: System headers (angle brackets)
    
    File->>ThirdP: #include &lt;torch/...&gt;<br/>#include &lt;gtest/...&gt;
    Note over File,ThirdP: Third-party headers (angle brackets)
    
    File->>ProjH: #include "fusion.h"<br/>#include "ir/all_nodes.h"<br/>#include "tests/cpp/..."
    Note over File,ProjH: Project local headers (quotes)

Loading

[wujingyue]

!test

[wujingyue]

!test