-
Notifications
You must be signed in to change notification settings - Fork 73
Reorder multidevice test includes #5745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
wujingyue
commented
Jan 2, 2026
- Convert local includes in multidevice tests to quote style
- Reorder include blocks to match Google C++ include ordering
- Add blank lines between third-party include groups and drop unused torch include
|
!test |
Description
|
| Relevant files | |||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Formatting | 14 files
|
PR Reviewer Guide
Here are some key observations to aid the review process:
| 🧪 PR contains tests |
| 🔒 No security concerns identified |
| ⚡ Recommended focus areas for review |
Greptile SummaryThis PR standardizes include directives across 14 multidevice test files to follow Google C++ style guidelines. Changes include:
All changes are purely organizational and do not modify any functional code. The includes remain correctly ordered per the project's Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant OldStyle as "Before: Angle Brackets"
participant Transform as "PR Changes"
participant NewStyle as "After: Google C++ Style"
OldStyle->>Transform: "<cuda.h><br/><gtest/gtest.h><br/><fusion.h>"
Transform->>Transform: "Group by priority<br/>Add blank lines"
Transform->>NewStyle: "System headers<br/>Third-party headers<br/>Local headers in quotes"
Note over Transform: Convert to quote style<br/>and reorder includes
|