-
Notifications
You must be signed in to change notification settings - Fork 73
Convert local includes in multidevice tests to quote style #5745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
wujingyue
commented
Jan 2, 2026
- Convert local includes in multidevice tests to quote style
- Reorder include blocks to match Google C++ include ordering
- Add blank lines between third-party include groups and drop unused torch include
|
!test |
|
Review updated until commit 49d1c02 Description
|
| Relevant files | |||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Enhancement | 18 files
|
PR Reviewer Guide
Here are some key observations to aid the review process:
| 🧪 PR contains tests |
| ⚡ No major issues detected |
Greptile SummaryThis PR performs a comprehensive code style cleanup across 18 multidevice test files by reordering includes to match Google C++ style guide and converting local includes from angle bracket syntax to quote syntax. The changes include:
All changes are purely stylistic with zero functional impact. The PR correctly implements the include ordering standard where:
The refactoring improves code consistency and makes the codebase easier to navigate by establishing a uniform include style across all multidevice test files. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Compiler
participant StdLib as "Standard Library"
participant ThirdParty as "Third-Party"
participant Local as "Local Project"
Compiler->>StdLib: "Search includes first"
StdLib-->>Compiler: "Found"
Compiler->>ThirdParty: "Then search third-party"
ThirdParty-->>Compiler: "Found"
Compiler->>Local: "Finally search local"
Local-->>Compiler: "Found"
Note over Compiler,Local: "Google C++ Include Order Pattern"
|
|
!test |