Skip to content

Conversation

@wujingyue
Copy link
Collaborator

  • Convert local includes in multidevice tests to quote style
  • Reorder include blocks to match Google C++ include ordering
  • Add blank lines between third-party include groups and drop unused torch include

@wujingyue wujingyue requested a review from naoyam January 2, 2026 06:58
@wujingyue
Copy link
Collaborator Author

!test

@github-actions
Copy link

github-actions bot commented Jan 2, 2026

Description

  • Convert local includes from angle brackets to quote style across all multidevice test files

  • Reorder include blocks to follow Google C++ include ordering guidelines

  • Add blank lines between third-party include groups for better readability

  • Remove unused torch include from test_multidevice_host_ir.cpp

Changes walkthrough

Relevant files
Formatting
14 files
test_multidevice_communications.cpp
Convert includes to quote style and reorder                           
+14/-14 
test_multidevice_communicator.cpp
Convert local includes to quote style                                       
+2/-2     
test_multidevice_host_ir.cpp
Convert includes and remove unused torch header                   
+8/-8     
test_multidevice_host_ir_overlap.cpp
Convert local includes to quote style                                       
+8/-8     
test_multidevice_ipc.cpp
Convert includes and reorder include groups                           
+9/-8     
test_multidevice_lower_communication.cpp
Convert includes and reorder include blocks                           
+10/-11 
test_multidevice_lower_communication_cuda.cpp
Convert includes and reorder include groups                           
+13/-13 
test_multidevice_matmul.cpp
Convert local includes to quote style                                       
+16/-16 
test_multidevice_pipeline.cpp
Convert includes and reorder include blocks                           
+30/-32 
test_multidevice_sharding.cpp
Convert local includes to quote style                                       
+8/-8     
test_multidevice_stream_parallel_type.cpp
Convert local includes to quote style                                       
+11/-11 
test_multidevice_symmetric_tensor.cpp
Convert local includes to quote style                                       
+2/-2     
test_multidevice_transformer.cpp
Convert local includes to quote style                                       
+6/-6     
test_multidevice_tutorial.cpp
Convert local includes to quote style                                       
+8/-8     

PR Reviewer Guide

Here are some key observations to aid the review process:

🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 2, 2026

Greptile Summary

This PR standardizes include directives across 14 multidevice test files to follow Google C++ style guidelines. Changes include:

  • Converting local project includes from angle bracket style (<header.h>) to quote style ("header.h")
  • Reordering includes into three groups with blank line separators: (1) system/standard library headers, (2) third-party headers like gtest, (3) local project headers
  • Removing an unused torch include from test_multidevice_pipeline.cpp
  • Adding blank lines between include groups where missing

All changes are purely organizational and do not modify any functional code. The includes remain correctly ordered per the project's .clang-format configuration which has SortIncludes: true enabled, ensuring automated formatting consistency.

Confidence Score: 5/5

  • This PR is safe to merge with no functional risk - it only reorders includes and changes bracket style.
  • Score of 5 reflects that this PR makes purely organizational changes to include directives with zero functional impact. All 14 files follow identical patterns: converting to Google C++ style with proper grouping and blank line separators. The removal of the unused torch include has been verified as safe. No code logic, behavior, or dependencies are affected. Changes align with the project's clang-format configuration.
  • No files require special attention

Important Files Changed

Filename Overview
tests/cpp/test_multidevice_communications.cpp Converted local includes from angle brackets to quote style and reordered to match Google C++ style: system headers (<cuda.h>), third-party headers (<gtest/gtest.h>), then local project headers in quotes.
tests/cpp/test_multidevice_communicator.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_host_ir.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_host_ir_overlap.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_ipc.cpp Converted local includes from angle brackets to quote style, added blank line separator between system and local includes, and maintained proper ordering.
tests/cpp/test_multidevice_lower_communication.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_lower_communication_cuda.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_matmul.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_pipeline.cpp Reordered includes to match Google C++ style: standard library headers, then third-party headers (<gtest/gtest.h>), then local project headers in quotes. Removed unused torch include.
tests/cpp/test_multidevice_sharding.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_stream_parallel_type.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_symmetric_tensor.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_transformer.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.
tests/cpp/test_multidevice_tutorial.cpp Converted local includes from angle brackets to quote style and reordered following Google C++ include ordering guidelines.

Sequence Diagram

sequenceDiagram
    participant OldStyle as "Before: Angle Brackets"
    participant Transform as "PR Changes"
    participant NewStyle as "After: Google C++ Style"
    
    OldStyle->>Transform: "<cuda.h><br/><gtest/gtest.h><br/><fusion.h>"
    Transform->>Transform: "Group by priority<br/>Add blank lines"
    Transform->>NewStyle: "System headers<br/>Third-party headers<br/>Local headers in quotes"
    
    Note over Transform: Convert to quote style<br/>and reorder includes
Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants