You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getCUDAStream method has been significantly simplified by using try_emplace and removing explicit device index specification when creating streams. This changes the stream creation behavior from explicitly specifying device index to using the default device. While this simplifies the code, it should be verified that this doesn't break multi-GPU scenarios where streams need to be created on specific devices.
c10::cuda::CUDAStream HostIrEvaluator::getCUDAStream(Stream* stream) {
StreamKey stream_key = stream;
// if stream points to an index, it represents the dynamic value of that indexif (Val* index = stream->index(); index != nullptr) {
auto value = expr_evaluator_.evaluate(index);
NVF_ERROR(value.hasValue() && value.is<int64_t>());
stream_key = value.as<int64_t>();
}
auto [it, inserted] =
streams_.try_emplace(stream_key, c10::cuda::getStreamFromPool());
return it->second;
}
Test parameters were reduced from 4 values (2MB, 8MB, 32MB, 128MB, 256MB) to 3 values (2MB, 8MB, 32MB), removing the 128MB and 256MB test cases. This reduces test coverage for larger memory sizes and should be justified or the removed test cases should be restored if they provide important coverage.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.