Skip to content

Conversation

@naoyam
Copy link
Collaborator

@naoyam naoyam commented Dec 20, 2025

No description provided.

@naoyam
Copy link
Collaborator Author

naoyam commented Dec 20, 2025

!test

@github-actions
Copy link

github-actions bot commented Dec 20, 2025

Review updated until commit 2d73448

Description

  • Enable TensorIndexer for all C++ tests by setting IdModel option to "all"

  • Add option configuration in NVFuserTest SetUp method

  • Ensures consistent TensorIndexer behavior across test suite

Changes walkthrough

Relevant files
Enhancement
utils.cpp
Enable TensorIndexer in test setup                                             

tests/cpp/utils.cpp

  • Added EnableOptionsGuard configuration in NVFuserTest::SetUp()
  • Set EnableOption::IdModel to {"all"} to enable TensorIndexer
  • Ensures all C++ tests run with TensorIndexer enabled
  • +1/-0     

    PR Reviewer Guide

    Here are some key observations to aid the review process:

    🧪 PR contains tests
    ⚡ Recommended focus areas for review
    Feature Enablement Impact

    This change globally enables TensorIndexer with "all" option for every C++ test. While the change itself is simple, reviewers should verify: 1) This is the intended behavior for all tests, 2) No existing tests rely on TensorIndexer being disabled by default, 3) The "all" option is appropriate for the test suite, and 4) Any potential test failures or behavioral changes are acceptable.

    EnableOptionsGuard::getCurOptions().set(EnableOption::IdModel, {"all"});

    @naoyam
    Copy link
    Collaborator Author

    naoyam commented Dec 20, 2025

    !test

    @naoyam
    Copy link
    Collaborator Author

    naoyam commented Jan 7, 2026

    !test

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    2 participants