feat: Support more Data Designer seed sources#413
Conversation
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
…rted Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
…d sources Signed-off-by: Mike Knepper <mknepper@nvidia.com>
Signed-off-by: Mike Knepper <mknepper@nvidia.com>
📝 WalkthroughWalkthroughAdds remote filesystem seed support ( ChangesRemote Filesystem Seed Support
Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/data_designer_nemo/tests/unit/test_remote_filesystem_seeds.py (1)
4-4: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRemove postponed annotations import in this test module.
Line 4 enables postponed/string-based annotations; keep runtime-resolved concrete hints instead.
Suggested change
-from __future__ import annotations - from typing import AnyAs per coding guidelines "Always prefer concrete type hints over string-based ones in Python code; do not import types under TYPE_CHECKING, instead import types as regular imports when possible".
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/data_designer_nemo/tests/unit/test_remote_filesystem_seeds.py` at line 4, Remove the `from __future__ import annotations` import statement from the top of the test_remote_filesystem_seeds.py module. This import enables postponed evaluation of annotations (string-based type hints), but the coding guidelines require using concrete type hints instead of string-based ones. Delete this single import line and ensure any type annotations in the module use direct type references rather than string representations.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/data_designer_nemo/tests/unit/test_remote_filesystem_seeds.py`:
- Line 4: Remove the `from __future__ import annotations` import statement from
the top of the test_remote_filesystem_seeds.py module. This import enables
postponed evaluation of annotations (string-based type hints), but the coding
guidelines require using concrete type hints instead of string-based ones.
Delete this single import line and ensure any type annotations in the module use
direct type references rather than string representations.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: e07ae8ef-d677-42f9-9166-d1e26b92627d
📒 Files selected for processing (15)
packages/data_designer_nemo/src/data_designer_nemo/context.pypackages/data_designer_nemo/src/data_designer_nemo/fileset_filesystem_provider.pypackages/data_designer_nemo/src/data_designer_nemo/model_provider.pypackages/data_designer_nemo/src/data_designer_nemo/seed.pypackages/data_designer_nemo/src/data_designer_nemo/unsupported_features.pypackages/data_designer_nemo/tests/unit/test_fileset_filesystem_provider.pypackages/data_designer_nemo/tests/unit/test_model_configs.pypackages/data_designer_nemo/tests/unit/test_remote_filesystem_seeds.pyplugins/nemo-data-designer/src/nemo_data_designer_plugin/testing/utils.pyplugins/nemo-data-designer/tests/integration/test_preview_remote_sdk.pyplugins/nemo-data-designer/tests/integration/test_remote_validation_errors.pyplugins/nemo-data-designer/tests/integration/test_validate_sdk.pyplugins/nemo-data-designer/tests/unit/test_model_provider.pyplugins/nemo-data-designer/tests/unit/test_preview_function.pyplugins/nemo-data-designer/tests/unit/test_sdk_resources.py
💤 Files with no reviewable changes (3)
- plugins/nemo-data-designer/tests/integration/test_remote_validation_errors.py
- plugins/nemo-data-designer/tests/unit/test_model_provider.py
- packages/data_designer_nemo/src/data_designer_nemo/model_provider.py
|
Adds support for
DirectorySeedSourceandFileContentsSeedSourceseed datasets in remote contexts. Depends on NVIDIA-NeMo/DataDesigner#765 getting merged and a new release of the library getting published.Summary by CodeRabbit
Release Notes
New Features
Tests