Skip to content

[don't merge] split train and val dataset in preference dataset #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
yuki-97 wants to merge 47 commits into
base: main
Choose a base branch
from
Draft

[don't merge] split train and val dataset in preference dataset #1763

yuki-97 wants to merge 47 commits into from

Conversation

@yuki-97
Copy link
Contributor

@yuki-97 yuki-97 commented Jan 13, 2026 •
edited
Loading

Closes #1050.

yuki-97 and others added 30 commits January 8, 2026 07:45
@yuki-97
update response dataset unit test as example
dd7e6b7 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
split train and val at run_grpo and response_dataset
b0c2f70 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update OpenMathInstruct2Dataset
2665828 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update clevr
cf55d5c 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update vlm datasets
9b48127 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
remove clevr_cogent, always to use clevr-cogent
57a4f61 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
remove openmathinstruct2, always to use OpenMathInstruct-2
6dd5e08 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update DAPOMath
423aa0a 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update DeepScaler
e45b191 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update HelpSteer3
f87eec1 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update squad
892eb8f 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update tulu3
a55cc3a 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update oasst
5ee0574 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update oai
35c5bd2 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
lint
c4c5b9e 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
pyrefly
cdf376f 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update doc
10bb125 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
fix unit test
71bab37 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@RayenTian @yuki-97
split run_sft and run_distillation_math (#1656)
49d8be7 
Signed-off-by: Rayen <ruit@nvidia.com>
@yuki-97
update run_grpo_xxx
cafa973 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
unify
dcc111a 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
fix rebase
99a28ab 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
use common func to support split_train_validation
fc43ca9 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update doc for split_validation_size
f615a8d 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
unify docstring
cadb14c 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
fix task_name in oai dataset
6351c5d 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
fix functional test
93bd3ed 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
use inherit
b0efc41 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
address doc comments
9b2eeec 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
remove test comments
252c6d1 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jan 13, 2026
@yuki-97 yuki-97 linked an issue Jan 13, 2026 that may be closed by this pull request
Decouple train and eval dataset #1050
Open
@yuki-97 yuki-97 mentioned this pull request Jan 13, 2026
Open
@yuki-97
update doc
3be3a62 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
split PreferenceDatasetConfig
bcec495 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97
update config
99fa7d3 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97 yuki-97 changed the base branch from yukih/split-train-val-dataset to main January 13, 2026 08:22
@yuki-97 yuki-97 added the CI:L1 Run doctests, unit tests, and functional tests label Jan 13, 2026
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Jan 13, 2026
@yuki-97 yuki-97 force-pushed the yukih/split-train-val-dataset-preference branch from 0923975 to 2fb1777 Compare January 13, 2026 11:32
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Jan 13, 2026
@yuki-97 yuki-97 force-pushed the yukih/split-train-val-dataset-preference branch from 2fb1777 to 6086b51 Compare January 13, 2026 14:38
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Jan 13, 2026
@yuki-97
fix test
994a15f 
Signed-off-by: Yuki Huang <yukih@nvidia.com>
@yuki-97 yuki-97 force-pushed the yukih/split-train-val-dataset-preference branch from 6086b51 to 994a15f Compare January 13, 2026 15:26
@yuki-97 yuki-97 added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L1 Run doctests, unit tests, and functional tests labels Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CI:L1 Run doctests, unit tests, and functional tests documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Decouple train and eval dataset

3 participants

@yuki-97 @RayenTian