Skip to content

Conversation

@mxinO
Copy link

@mxinO mxinO commented Jan 10, 2026

What does this PR do ?

Add quantization aware (QA) training, e.g. QA-GRPO, QA-On policy distillation.

Usage

Run a QARL by enabling simulated quantization with modelopt, adding the following config,

++policy.generation.quant_cfg="NVFP4_DEFAULT_CFG" \
++policy.quant_cfg="NVFP4_DEFAULT_CFG" \

Other quantization formats are available, but currently only tensor-wise quantization format are supported.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Meng Xin <mxin@nvidia.com>
@github-actions
Copy link

⚠️ File Consistency Check

Check based on commit: 4f14851 (PR #1756 from mxin/qarl-3)

⚠️ DTensor Policy Worker Synchronization Warning

The file nemo_rl/models/policy/workers/dtensor_policy_worker_v2.py was modified in this PR, but nemo_rl/models/policy/workers/dtensor_policy_worker.py was not updated.

Why this matters:
These files contain related DTensor policy worker implementations that should be kept synchronized to ensure consistency across different versions.

Action required:

  • Please review if the changes in nemo_rl/models/policy/workers/dtensor_policy_worker_v2.py should also be applied to nemo_rl/models/policy/workers/dtensor_policy_worker.py
  • Update nemo_rl/models/policy/workers/dtensor_policy_worker.py if necessary to maintain consistency
  • If the files are intentionally different, please add a comment in the PR explaining why

Files to check:

  • Modified: nemo_rl/models/policy/workers/dtensor_policy_worker_v2.py
  • Not modified: nemo_rl/models/policy/workers/dtensor_policy_worker.py

This check ensures that related file implementations remain synchronized across the codebase. If you believe this warning is incorrect or the files should intentionally differ, please add a comment explaining the reasoning.

mxinO added 4 commits January 13, 2026 23:04
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
@guyueh1 guyueh1 self-requested a review January 14, 2026 17:28
Copy link

@realAsma realAsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mxinO Is it possible to consolidate all ModelOpt related modifications to one folder (following the patch based integration ModelOpt adopted For MCore, Huggingface etc..)?

mxinO added 3 commits January 14, 2026 23:49
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Signed-off-by: Meng Xin <mxin@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants