[ci] Refactor Gemma3-VL launch script to run finetune and packed tests separately#2730
Merged
theothermike merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
…arately Split the single torch.distributed.run invocation into two separate launches so that test_gemma3_vl_finetune_recipes and test_gemma3_vl_finetune_packed_recipes each run in their own process, improving test isolation. Signed-off-by: Chen Cui <chcui@nvidia.com> Made-with: Cursor
Contributor
📝 WalkthroughWalkthroughA test script is updated to add a new pytest execution block for Gemma3-VL finetune recipes and refine the existing finetune packed recipes test to use a specific test filter instead of running all tests in the file. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
theothermike
approved these changes
Mar 11, 2026
Contributor
theothermike
left a comment
There was a problem hiding this comment.
tested and confirmed it resolves the segfault in the test
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactor the Gemma3-VL recipe functional test launch script to run
test_gemma3_vl_finetune_recipesandtest_gemma3_vl_finetune_packed_recipesas separatetorch.distributed.runinvocations for better test isolation.Changelog
torch.distributed.runinvocation inL2_Launch_recipes_gemma_vl.shinto two separate launches using pytest-kto select each test individuallyGitHub Actions CI
See the CI section in the Contributing doc for how to trigger the CI.
A Nvidia developer will need to approve and trigger the CI for external contributors.
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information
N/A
Made with Cursor
Summary by CodeRabbit